Bugzilla – Full Text Bug Listing
| Summary: | [hovering] NPE in JavadocHover when annotation value is a primitive type | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Chris Stodden <chris.stodden> | ||||
| Component: | Text | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, deepakazad, markus.kell.r, Olivier_Thomann | ||||
| Version: | 3.6 | Flags: | daniel_megert:
review+
deepakazad: review+ Olivier_Thomann: review+ |
||||
| Target Milestone: | 3.6 RC3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
We have reworked that code after I20100429-1549. Can you please retry with 3.6 RC2 and report back? If you can still reproduce then please attach your example. Got it. To reproduce, hover over Bug314585. @Classes({int.class}) public class Bug314585 { } @interface Classes { Class<?>[] value(); } I think we should fix this, since this code is quite new. Created attachment 170216 [details]
Fix
Is it possible to get a regression test for it ? +1. A null check is required as primitive types don't have a java element. > Is it possible to get a regression test for it ?
Not at this time, we don't have regression tests for the hover contents. This is UI-related code that generates HTML. Since the output is not well-defined and changes a lot over time, it's not easy to write a stable test suite. We should probably better separate the business logic from the presentation and then write tests for the business logic.
Looks good. Released to HEAD. +1 for RC3 - this worth getting fixed. . Verified in I20100527-1700. Verified with I20100530-0800 |
Build Identifier: I20100429-1549 From within the java editor, hovering over the interface (Service1Soap) of an implementation such as: "public class Service1_Service1SoapImpl implements Service1Soap {..." Produces the following stack trace: java.lang.NullPointerException at org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabelComposer.appendElementLabel(JavaElementLabelComposer.java:263) at org.eclipse.jdt.internal.ui.viewsupport.JavaElementLinks.getElementLabel(JavaElementLinks.java:514) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.addValue(JavadocHover.java:1013) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.addValue(JavadocHover.java:1040) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.addAnnotation(JavadocHover.java:1003) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.getAnnotations(JavadocHover.java:980) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.addAnnotations(JavadocHover.java:928) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.getHoverInfo(JavadocHover.java:595) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.internalGetHoverInfo(JavadocHover.java:546) at org.eclipse.jdt.internal.ui.text.java.hover.JavadocHover.getHoverInfo2(JavadocHover.java:538) at org.eclipse.jdt.internal.ui.text.java.hover.BestMatchHover.getHoverInfo2(BestMatchHover.java:141) at org.eclipse.jdt.internal.ui.text.java.hover.JavaEditorTextHoverProxy.getHoverInfo2(JavaEditorTextHoverProxy.java:82) at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166) The interface class is contained within a jar. Reproducible: Always Steps to Reproduce: 1.Create a Dynamic Web Project 2.Import a jar with a webservice endpoint interface 3.Create a service implementation that references this interface 4.Hover over the interface name from the implementation (I have a jar and implementation available let me know thxs)