Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314564

Summary:

[tcf][patch] org.eclipse.tm.tcf.core.AbstractChannel#write() mangles binary data

Product:

[Tools] TCF

Reporter:

Ed Swartz <ed.swartz>

Component:

Core

Assignee:

Project Inbox <dsdp.tm.tcf-inbox>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

major

Priority:

CC:

cdtdoug, eugene

Version:

unspecified

Target Milestone:

0.3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	eugene: iplog+

Description Ed Swartz

2010-05-26 15:59:50 EDT

We're implementing a custom channel from AbstractChannel and when using the filesystem service and a binary payload, we found that our channel implementation was cutting off messages unexpectedly.  

It looks like a simple Java coding error in #write(byte[]) -- since bytes are sign extended when passed as int, a few of these will look like MARKER_EOM and MARKER_EOS.

Comment 1 Ed Swartz

2010-05-26 16:00:39 EDT

Created attachment 170091 [details]
patch

Comment 2 Eugene Tarassov

2010-05-26 17:16:36 EDT

I have committed the fix.
Thanks!

Comment 3 Martin Oberhuber

2010-05-28 14:09:00 EDT

Bulk update: Marking all TCF fixes from the Helios period (2009-06-29 until 2010-06-01) as target 3.2 since they go through release review along with the TM 3.2 release.

Comment 4 Doug Schaefer

2011-05-17 10:49:25 EDT

Moving bugs to new home for IP log.

Comment 5 Martin Oberhuber

2013-06-05 06:26:50 EDT

Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3