Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314561

Summary: Add missing help contexts
Product: [Eclipse Project] PDE Reporter: Curtis Windatt <curtis.windatt.public>
Component: DocAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, daniel_megert, darin.eclipse, john.arthorne
Version: 3.6Flags: darin.eclipse: review+
ankur_sharma: review+
john.arthorne: review+
Target Milestone: 3.6 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 310469, 310493    
Attachments:
Description Flags
Fix none

Description Curtis Windatt CLA 2010-05-26 15:43:59 EDT
There are missing contexts on two dialogs in PDE.  We need to add the contexts so we can add context sensitive help doc.
Comment 1 Curtis Windatt CLA 2010-05-26 15:44:57 EDT
The two contexts are for the target export wizard and the import plug-in from cvs detailed page.
Comment 2 Curtis Windatt CLA 2010-05-26 15:54:01 EDT
Created attachment 170088 [details]
Fix
Comment 3 Curtis Windatt CLA 2010-05-26 15:54:37 EDT
Darin, Ankur, Dani, please review as soon as you are able.
Comment 4 Ankur Sharma CLA 2010-05-26 16:09:36 EDT
+1
Comment 5 Darin Wright CLA 2010-05-26 16:15:03 EDT
For the CVS wizard page, should the help be registered on the local "comp" or the passed in "parent" composite? (For the other import wizard pages, the local composite container is used).
Comment 6 Curtis Windatt CLA 2010-05-26 16:37:42 EDT
(In reply to comment #5)
> For the CVS wizard page, should the help be registered on the local "comp" or
> the passed in "parent" composite? (For the other import wizard pages, the local
> composite container is used).

It shouldn't matter in this case as the locally create composite simply fills the parent composite.  The fix can be easily changed to use the local comp.
Comment 7 Curtis Windatt CLA 2010-05-26 17:04:31 EDT
Dani is out for the day, adding John A instead.
Comment 8 Curtis Windatt CLA 2010-05-26 22:15:12 EDT
Fixed in HEAD.  Thanks John.