Bugzilla – Full Text Bug Listing
| Summary: | Accept Heap Instance data requests only when enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Joel Cayne <jcayne> | ||||
| Component: | TPTP | Assignee: | Joel Cayne <jcayne> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | jgwest, mikereid | ||||
| Version: | unspecified | Flags: | kathy:
pmc_approved?
(oec) kathy: pmc_approved? (ernest) kathy: pmc_approved? (kathy) kathy: pmc_approved? (paulslau) jgwest: pmc_approved+ |
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 314543 | ||||||
| Attachments: |
|
||||||
Patch looks good. I would like to request for PMC approval to include the fix of this bug in TPTP v4.7.0. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? This updates the heap instance data collection request command to send a response only when the option for this extension has been enabled. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Mike 6. Is there a test case attached to the bugzilla record? No. A test case will be added as part of bug 314543. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Low. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a Requesting PMC approval for TPTP 4.7. Patch checked into HEAD. Closing. |
Created attachment 170049 [details] Patch to ACCollector A request for heap instance data collection should not be handled when the option is not enabled. The attached patch checks if the option has been enabled. Mike, Can you please review? Thanks!