Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314522

Summary: Web service wizard Service Deployment Configuration view options corrupt each other
Product: [WebTools] WTP Webservices Reporter: Eric Peters <ericdp>
Component: jst.wsAssignee: Eric Peters <ericdp>
Status: RESOLVED FIXED QA Contact: Keith Chong <keith.chong.ca>
Severity: normal    
Priority: P1 CC: neil.hauge, raghunathan.srinivasan
Version: 3.2Flags: keith.chong.ca: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
keith.chong.ca: pmc_approved? (naci.dai)
keith.chong.ca: pmc_approved? (deboer)
neil.hauge: pmc_approved+
keith.chong.ca: pmc_approved? (kaloyan)
keith.chong.ca: review+
Target Milestone: 3.2 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
screen capture- shows badly sized panel cannot see all the runtime in list
none
patch for review none

Description Eric Peters CLA 2010-05-26 12:56:02 EDT
Created attachment 170045 [details]
screen capture- shows badly sized panel cannot see all the runtime in list

The web service wizard page "Service Deployment Configuration" allows users
to select between 3 different views: Choose server first, Choose Web service
runtime first & Explore options.
- User can switch between each of these in turn and provided user makes no
changes all views display correctly.
- If user expands the Server Types information in any of the views and there
are a lot of servers defined (e.g. 6 or more), or 3 or more server types and
expands each them in turn, then switches to either the Choose server first or
Choose Web service runtime first views, one of the selection boxes becomes a
scrollable window displaying only one line of text at a time. Expanding the
size of the dialog reveals the other web service runtimes (there are supposed to be 3 showing).

See screen capture.
Comment 1 Eric Peters CLA 2010-05-26 12:56:43 EDT
Created attachment 170046 [details]
patch for review

Unit testing switching amongst the different options in the dialog and tests
fine (the server runtimes and servers panels are no worse than the same size
now so all the runtimes are now visible with effect that list of servers panel
may be a tiny bit smaller than before).
Comment 2 Eric Peters CLA 2010-05-26 15:39:37 EDT
1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 

An adopter is requesting this fix as reflect poorly on product quality.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient? 

Yes, can expand the dialog to reveal the missing fields, but the workaround may not be apparent.

3. How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 

Patch tested  thoroughly manually as per patch comment 1, tried several runtimes defined, several servers defined (existing & in preferences), and toggling between the options. 

4. Give a brief technical overview. Who has reviewed this fix? 
What is the risk associated with this fix? 

Very low risk of regression due to size and complexity of change (3 lines of code, just adding couple of hints as to the size of the panels). The 2 panels are roughly the same size now.
Comment 3 Keith Chong CLA 2010-05-26 15:50:51 EDT
Requesting PMC approval.
Comment 4 Eric Peters CLA 2010-05-26 18:45:50 EDT
Released to HEAD as org.eclipse.jst.ws.consumption.ui=v201005262244