Bugzilla – Full Text Bug Listing
| Summary: | NullPointer exception while disconnecting a non valid remote connection | ||
|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Emmanuel Geay <egeay> |
| Component: | Remote Tools | Assignee: | Greg Watson <g.watson> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | g.watson |
| Version: | 4.0 | ||
| Target Milestone: | 4.0 | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
Fixed in head. Should be in friday night's build. Please test. Thank you for the fix! The internationalized messages in such class (and also others of the project) are broken, since the class "org.eclipse.ptp.remotetools.core.messages.Messages" has not been updated appropriately after refactoring. The field BUNDLE_NAME should now be equals to: BUNDLE_NAME = "org.eclipse.ptp.remotetools.core.messages.messages"; //$NON-NLS-1$ in order to find the right properties file. Should be fixed now. Thanks. The fix needs to go also in PTP 3.0 branch. I've created another bug for this. Can you please give the other bugzilla item you created? I can't manage to find it. The problem is still present in PTP 3.0 branch. Thanks. |
1) Call org.eclipse.ptp.remotetools.internal.ssh.Connection.connect method. 2) If connection to remote host failed, then a call to disconnect will occur. try { defaultSession.connect(timeout); } catch (JSchException e) { disconnect(); throw new RemoteConnectionException( Messages.Connection_Connect_FailedConnect, e); } catch (Exception e) { disconnect(); throw new RemoteConnectionException( Messages.Connection_Connect_FailedUnsupportedKeySize, e); } 3) Line with "while (!sftpChannelPool.isEmpty())" will create a NPE, since the collection is initialized after in the control flow of "connect" method.