Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314493

Summary:

Improve phpdoc look in content assist

Product:

z_Archived

Reporter:

Jacek Pospychala <jacek.pospychala>

Component:

PDT

Assignee:

Zhongwei Zhao <zhaozhongwei>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

gadi, legend7z

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
screenshot	none
patch	none
new patch	jacek.pospychala: iplog+
example	none

Description Jacek Pospychala

2010-05-26 11:59:44 EDT

PHPdocs have received lot of love recently in bug 311734 however in content assist they still look old and ugly.
It would be cool to update the way how phpdocs appear in content assist too.

Comment 1 Jacek Pospychala

2010-05-26 12:04:56 EDT

Created attachment 170030 [details]
screenshot

difference between phpdoc on hover and content-assist

Comment 2 Jacek Pospychala

2010-05-26 12:09:41 EDT

hi Xu,
want to take a look at this one too? :-)

Comment 3 xu jiaxi

2010-05-27 10:31:44 EDT

Created attachment 170191 [details]
patch

Hi Jacek,
Here is the patch, you can try it.

Comment 4 xu jiaxi

2010-05-27 11:12:01 EDT

Created attachment 170199 [details]
new patch

Comment 5 Jacek Pospychala

2010-06-08 07:33:01 EDT

thanks Xu,

the patch works great for me, the improved tooltip is light years more readable. I tried it with constants/vars, functions and types and all looks fine.

I noticed only one issue, that also appears in non-CA tooltip. It's that contents of phpdoc after an empty line are not included in tooltip.
For example:

/** Line1
 *
 * Line3
 * 
 * @author jacek
 *
 */
class Boo {
	
}

hovering over Boo (or tooltip in content-assist), will show only "Line1", but not "Line3".

This is not a big issue, however, typically PDT generates phpdoc blocks like:
/**
 * 
 * Enter description here ...
 * @author jacek
 *
 */

And because of empty line, the "Enter description here..." doesn't appear in tooltip.

Comment 6 Jacek Pospychala

2010-06-08 07:34:04 EDT

Created attachment 171385 [details]
example

example to above comment

Comment 7 Zhongwei Zhao

2010-06-10 06:05:18 EDT

Thanks,Xu!Contributed by Xu.

Comment 8 Zhongwei Zhao

2010-06-10 06:07:01 EDT

mark fixed

Comment 9 Jacek Pospychala

2010-06-17 09:21:22 EDT

Regarding commen 5, I opened separate bug 317172 -  Long description missing in tooltips

Comment 10 Gadi Goldbarg

2010-06-17 10:52:38 EDT

Verified at PDT-2.2.0.v20100616 
At tooltip at CA presented at the new line with mentioned issue reported by Jacek

Closing this issue...

Verified by
Teodor Kirkov
teodor.k@zend.com