Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314475

Summary:

Advanced button not working again

Product:

[Eclipse Project] Platform

Reporter:

Szymon Brandys <Szymon.Brandys>

Component:

Assignee:

Platform-UI-Inbox <Platform-UI-Inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bokowski, camle, cdeadmin, kitlo, pawel.pogorzelski1, remy.suen, serge

Version:

3.6

Flags:

serge: review+
bokowski: review+
pawel.pogorzelski1: review+

Target Milestone:

3.6 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Fix v01	none

Description Szymon Brandys

2010-05-26 10:47:06 EDT

This is caused by the fix for bug 312888. See also bug 311599, comment 19 and the following comments.

Comment 1 Szymon Brandys

2010-05-26 10:49:48 EDT

Created attachment 170007 [details]
Fix v01

Serge, could you verify that the fix is ok? Thanks.

Comment 2 Serge Beauchamp

2010-05-26 10:59:42 EDT

That looks good, thanks Szymon

Comment 3 Boris Bokowski

2010-05-26 11:30:01 EDT

Do you have reproducible steps for this? The patch looks safe (only adding a null check) but I would like to be able to see the problem and that this fix actually solves the problem.

Comment 4 Szymon Brandys

2010-05-26 11:51:59 EDT

Sure, the steps are as follows:

1) Install Data Tools from the Helios update site to you Eclipse SDK
2) Start Eclipse and create a project (it may be a Java project)
3) Try to create a new SQL file in the project, New > Other > SQL Development > SQL File
4) Click 'Advanced' on the opened New SQL File wizard

You should see NPE logged

5) Resize the dialog and see multiple Advanced sections, see https://bugs.eclipse.org/bugs/attachment.cgi?id=169892

Comment 5 Szymon Brandys

2010-05-26 12:25:18 EDT

Committed to HEAD.

Comment 6 Serge Beauchamp

2010-05-27 05:44:37 EDT

*** Bug 314417 has been marked as a duplicate of this bug. ***