Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314473

Summary: Move ControlDecoratorLCA to appropriate package
Product: [RT] RAP Reporter: Benjamin Muskalla <b.muskalla>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: trivial    
Priority: P3    
Version: 1.3   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Benjamin Muskalla CLA 2010-05-26 10:41:32 EDT
ControlDecoratorLCA currently lives in org.eclipse.swt.internal.internal.widgets.controldecoratorkit and should be moved to org.eclipse.swt.internal.widgets.controldecoratorkit;
Comment 1 Ralf Sternberg CLA 2010-05-27 06:25:35 EDT
+1, same for ControlDecoratorLCA_Test
Comment 2 Ralf Sternberg CLA 2011-09-22 07:49:19 EDT
Although it looks like a typo, it's actually correct. The naming convention for LCAs demand that an "internal." segment is added to the package of the widget. The ControlDecorator lives in an internal package already, another "internal." segment has to be added.

If we'd change the LCA lookup code to also accept a single internal in this case we could not differentiate LCAs in the (unlikely) case that we'd have a public and an internal widget of the same name, e.g. foo.Bar and foo.internal.Bar. I think we can live with the "internal.internal" for the rare case of internal widgets.