Bugzilla – Full Text Bug Listing
| Summary: | IllegalArgumentException seen in error log during test execution | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Ben Chen <chenbs> | ||||
| Component: | TPTP | Assignee: | Bozier jerome <jerome.bozier> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | paulslau | ||||
| Version: | unspecified | Flags: | paulslau:
pmc_approved?
(oec) paulslau: pmc_approved? (ernest) kathy: pmc_approved+ paulslau: pmc_approved? (paulslau) paulslau: pmc_approved? (ewchan) paulslau: pmc_approved? (jgwest) paulslau: review+ |
||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 281877 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Ben Chen
Jerome, please check if this defect is an issue with the test case(s) or a functional issue. If a functional issue, please triage/size and deleiver a fix by EOD Friday. Thanks. first try, launched with "-clean" argument : i no longer see theses exceptions
second try : launched without this argument : i see theses exception occur
when looking closer, they are triggered when we try to extract things from :
L/SOA/Schedule-BOTH_1217449957696.trcmxmi
L/Google/GoogleTest_1216056499632.trcmxmi
etc....
when reading .metadata file, we discover that theses proxy have been created with a factory with ID "EMFResourceProxyFactory_4.3" (the same as ours....) and same "kind" of item as ours ("executionResultNode")
but it seems that format inside is not the same and our XML reader is unable to extract some field (especially name field)
the code after this protect us and re-create the proxy if the reading of saved proxy fail, but error message still appear.
simpler way to remove this message would be to remove the " UiPlugin.logError(e);" inside catch block of "deserializeProxyNode()" method in
"org.eclipse.hyades.test.ui.internal.navigator.proxy.FileProxyMetadataPersister" class
Paul, any thought ? i attach the patch that does this, use it if you feel it is OK
Created attachment 170223 [details]
patch
this patch remove the error logged when we fail to read a persisted proxy
(the proxy will still be re-created)
Paul, could you review / comment it ?
many thanks in advance
(In reply to comment #3) > Created an attachment (id=170223) [details] > patch > > this patch remove the error logged when we fail to read a persisted proxy > (the proxy will still be re-created) > > Paul, could you review / comment it ? > > many thanks in advance Reviewed and approved. Requesting PMC approval for TPTP 4.7.0: 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Extraneous error logged when de-serializing a malformed proxy marker. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. Regression from 281877. 4. Does this require new API? No. 5. Who performed the code review? Paul Slauenwhite 6. Is there a test case attached to the bugzilla record? Covered by existing test case(s). 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Remove the logged error since the proxy is automatically recreated. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No. The attached patch is checked in to CVS (HEAD). verified in TPTP-4.7.0-201006011014 (In reply to comment #6) > verified in TPTP-4.7.0-201006011014 Closing |