Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314410

Summary:

SQL Results Parameters tab should not appear when there are no parameters

Product:

[Tools] Data Tools

Reporter:

Brian Payton <bpayton>

Component:

SQL Results View

Assignee:

Brian Payton <bpayton>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

1.8

Target Milestone:

1.8

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch for plugin o.e.d.sqltools.result.ui	none

Description Brian Payton

2010-05-26 04:26:25 EDT

In DTP 1.6 the Parameters tab of the SQL Results view did not appear when there were no parameters in the statement that was executed.  Now the Parameters tab is there all the time, for every result.  The SQL Results view should be fixed so that the Parameters tab only appears when needed.

Comment 1 Brian Payton

2010-05-26 04:54:25 EDT

Created attachment 169951 [details]
Patch for plugin o.e.d.sqltools.result.ui

Comment 2 Brian Payton

2010-05-26 04:57:56 EDT

The fix is pretty simple.  There is code in the class MultipleTabsGridSection in plugin org.eclipse.datatools.sqltools.result.ui that only displays the parameter tab if the parameters list in the result instance is null.  There was a fix elsewhere in the code that now causes the case of no parameters to be represented by an empty parameter list rather than a null parameter list.  The fix is to check for *both* null and empty parameter to determine whether or not to display the parameter tab.

Comment 3 Brian Payton

2010-05-26 05:05:37 EDT

Checked in fix, tagged to v201005261700