Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314370

Summary: Reading Manifest Error when trying to setup a target platform from a p2 repository that has old-style plugins
Product: [Eclipse Project] PDE Reporter: Nalini Ganapati <nalinig>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: andrew_hoo, curtis.windatt.public, darin.eclipse
Version: 3.5.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 407765    
Bug Blocks:    
Attachments:
Description Flags
Snapshot of error message while loading the target platform
none
Sample old-style plugin with no Manifest.mf none

Description Nalini Ganapati CLA 2010-05-25 18:07:13 EDT 
Build Identifier: Eclipse 3.5.2 M20100211-1343

When trying to setup a target platform using Window:Preferences:Plugin-Development:Target Platform by adding content from a Software Site(a p2 repository), we are encountering the issue of "Error reading manifest...". See attachment for the error. 

The bundle causing this problem is an old-style plugin that only has a plugin.xml and no MANIFEST.MF. Converting the plugin to have a MANIFEST.MF allows it to get loaded as a target platform. However, the p2 installer itself has no problem installing this plugin, the installer downloaded it correctly into pde's bundlepool. Also, installed this plugin successfully using Help:Install New Software into the self-hosted instance. It is only pde that is not loading them into the target platform.

Reproducible: Always
Comment 1 Nalini Ganapati CLA 2010-05-25 18:08:53 EDT 
Created attachment 169910 [details]
Snapshot of error message while loading the target platform
Comment 2 Nalini Ganapati CLA 2010-06-16 15:22:17 EDT 
Is there any chance that this can be fixed in 3.6? We are running into too many instances of this.
Comment 3 Curtis Windatt CLA 2010-06-16 15:37:42 EDT 
PDE is done for 3.6.  We can consider backporting to 3.6.1 if a solid well-contained fix can be found.

Please attach one of the plug-ins that the manifest cannot be read.
Comment 4 Nalini Ganapati CLA 2010-06-16 23:54:02 EDT 
Created attachment 172089 [details]
Sample old-style plugin with no Manifest.mf
Comment 5 Curtis Windatt CLA 2010-08-09 16:11:22 EDT 
Using 3.6 code, I am able to create a target platform containing the sample plug-in you have provided.  I create a new target platform and add a new directory location pointing to the parent folder of the plug-in.

Are you able to create a target with a directory location?  It could be something unique about how the plug-in is installed into your Eclipse.
Comment 6 Curtis Windatt CLA 2010-09-01 16:26:16 EDT 
Removing milestone.  Works for me.  We need better steps to reproduce to do anything here.
Comment 7 Curtis Windatt CLA 2010-09-01 16:27:53 EDT 
In the screenshot provided, you are not using a p2 repository location, you are using a local installation.
Comment 8 Curtis Windatt CLA 2013-08-15 16:37:56 EDT 
Marking as WORKSFORME.  Support for old style plug-ins has been removed from the base platform, but works fine with the compatibility fragment installed.