Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314306

Summary: Test assets are allowed to have same, non-unique IDs
Product: z_Archived Reporter: Ben Chen <chenbs>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: major    
Priority: P1 CC: ewchan, jerome.bozier, oec, paulslau
Version: unspecifiedFlags: paulslau: pmc_approved? (ernest)
kathy: pmc_approved+
paulslau: pmc_approved? (paulslau)
ewchan: pmc_approved+
paulslau: pmc_approved? (jgwest)
paulslau: pmc_approved+
jerome.bozier: review+
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch. none

Description Ben Chen CLA 2010-05-25 12:36:36 EDT 
Build Identifier: TPTP-4.7.0-201005222133

Using TPTP-4.7.0-201005222133

see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=232089

Reproducible: Always

Steps to Reproduce:
1.Create java project, and a directory "dir" in it
2.Create a test asset, say, artifact, "art" in the project
3.Copy "art" into "dir", right click on both artifacts and open them with the system editor, choose winzip as the program
4.Open the resource file with an editor, find the id field and check that the two test assets have the same id.
Comment 1 Paul Slauenwhite CLA 2010-05-25 13:57:39 EDT 
See /org.eclipse.hyades.test.ui.navigator.tests/manual/Test.UI.TestNavigator_bugzilla_232089.testsuite.
Comment 2 Paul Slauenwhite CLA 2010-05-25 14:13:17 EDT 
Created attachment 169871 [details]
Patch.
Comment 3 Paul Slauenwhite CLA 2010-05-25 14:13:40 EDT 
Jerome, please review the attached patch.
Comment 4 Bozier jerome CLA 2010-05-27 07:01:59 EDT 
reviewed and approved, i forgot to change the ID if name did not change, my bad
Comment 5 Paul Slauenwhite CLA 2010-05-27 10:05:08 EDT 
Requesting PMC approval for TPTP 4.7.0: 

  1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?

Test assets created by a save-as operation has the same ID as the original test.

   2. Is there a work-around? If so, why do you believe the work-around is insufficient?

No.

   3. Is this a regression or API breakage? Explain.

N/A

   4. Does this require new API?

No.

   5. Who performed the code review?

Jerome Bozier

   6. Is there a test case attached to the bugzilla record?

Covered by existing test case(s).

   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?

When the new test asset is created by a save-as operation, generate a new ID.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

No.
Comment 6 Paul Slauenwhite CLA 2010-05-27 10:16:07 EDT 
Oliver, I think this is what you wanted to do.  Correct me if I am wrong.
Comment 7 Paul Slauenwhite CLA 2010-05-27 10:21:18 EDT 
The attached patch is checked in to CVS (HEAD).
Comment 8 Ben Chen CLA 2010-06-01 15:28:53 EDT 
verified in TPTP-4.7.0-201006011014
Comment 9 Ben Chen CLA 2010-06-01 15:29:04 EDT 
(In reply to comment #8)
> verified in TPTP-4.7.0-201006011014

closing