Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314295

Summary: Need java facet aliasing/compatibility for Ganymede stream
Product: [WebTools] WTP Common Tools Reporter: Chuck Bridgham <cbridgha>
Component: Faceted Project FrameworkAssignee: Konstantin Komissarchik <konstantin>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: major    
Priority: P1 CC: ccc, david_williams, ricec, yurykats
Version: 3.2Flags: ccc: review+
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch v1 none

Description Chuck Bridgham CLA 2010-05-25 11:44:14 EDT
After the changes that went into the current Helios release with bug 298906, we have realized several scenarios are still broken in regard to our project compatibility support in our adopter product.

The changes that preserved existing facet version/name format don't go far enough, if the user is required to change server targets for any reason, which may require an update to the java facet version.

These projects may upgrade the java version, but then are not shareable in the previous version because of the unrecognized java facet name and version.

This is a critical problem for us, and we are forced to request a patch on our previous maintenance stream, which is 3.0.5 Patch builds (Ganymede) - 

http://download.eclipse.org/webtools/patches/
Comment 1 Carl Anderson CLA 2010-05-26 09:01:04 EDT
Assigning to Konstantin.  Our latest 3.0.5 patches build is located at http://download.eclipse.org/webtools/patches/drops/R3.0.5/P-P20100521060523-20100521060523/
Please remember to use the R3_0_5_patches branch of any plugin that you might need in your workspace, if it exists.  Otherwise, please load the R3_0_5 version, if possible.
Comment 2 Chuck Bridgham CLA 2010-06-03 15:57:18 EDT
Raising priority..

Konstantin, is there anything I can write for justification?  We need to know the possible timeline on these patches
Comment 3 Konstantin Komissarchik CLA 2010-06-03 18:21:36 EDT
Hi Chuck,

It's a pretty busy time for us right now with Helios validation and a Helios-based product ramp down. It's unfortunate that we got distracted from this option when the original change was implemented as we could have had this implemented and tested already. What's the latest date by which you need this by? Also, what about Galileo?
Comment 4 Chuck Bridgham CLA 2010-06-07 14:24:09 EDT
Hi,

We have until early July before closing down our next maintenance release. Not sure if this is enough time, I will be able to help test etc...

we(IBM) are not too concerned with Galileo, as most of our maintenance releases are based on Ganymede.

Please let me know if you can contain this work - Thanks - Chuck
Comment 5 Konstantin Komissarchik CLA 2010-06-14 13:24:06 EDT
I can work on this week. Should have something to test in a few days.
Comment 6 Konstantin Komissarchik CLA 2010-06-14 15:58:37 EDT
Created attachment 171866 [details]
Patch v1

Patch is ready for testing. The patch includes the following:

1. The implementation of aliasing system in wst.common.project.facet.core plugin.
2. The declarations that back-map java to jst.java and 1.5/1.6 to 5.0/6.0 in jst.common.project.facet.core plugin.
3. The unit tests for the aliasing system in wst.common.project.facet.core.tests plugin.

I performed some amount of manual testing around this scenario and all framework unit tests pass. Over to you guys for further testing. Let me know if you run into issues.
Comment 7 Chuck Bridgham CLA 2010-06-15 10:25:22 EDT
Excellent - Thanks... will start testing today
Comment 8 Chuck Bridgham CLA 2010-06-15 16:05:32 EDT
I did some initial testing, and code review.. looks good...   I approve of this going into the next patch build
Comment 9 Chuck Bridgham CLA 2010-06-15 16:06:25 EDT
Carl added you to review... can you do the "common" review and legwork for patch inclusion?
Comment 10 Carl Anderson CLA 2010-06-17 17:21:04 EDT
Approve, but we need to test this well.
Comment 11 Carl Anderson CLA 2010-06-21 21:08:10 EDT
Committed to R3_0_5_patches