Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314279

Summary: Test project documentation smoke test failures.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P1 CC: ewchan, jcayne, jerome.bozier, paulslau
Version: unspecifiedFlags: paulslau: pmc_approved? (oec)
paulslau: pmc_approved? (ernest)
paulslau: pmc_approved+
paulslau: pmc_approved? (paulslau)
ewchan: pmc_approved+
paulslau: pmc_approved? (jgwest)
paulslau: review+
paulslau: review+
jcayne: review+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 314288    
Attachments:
Description Flags
Error 1.
none
Error 2.
none
Patch.
none
Patch (Part 2).
none
Patch (Part 3). none

Description Paul Slauenwhite CLA 2010-05-25 10:26:12 EDT
Created attachment 169836 [details]
Error 1.

Test project documentation smoke test failures.

See attached.
Comment 1 Paul Slauenwhite CLA 2010-05-25 10:26:36 EDT
Created attachment 169837 [details]
Error 2.
Comment 2 Paul Slauenwhite CLA 2010-05-25 10:47:43 EDT
Created attachment 169841 [details]
Patch.
Comment 3 Paul Slauenwhite CLA 2010-05-25 10:48:02 EDT
Jerome, please review the attached patch.
Comment 4 Bozier jerome CLA 2010-05-25 10:52:16 EDT
reviewed and approved
Comment 5 Paul Slauenwhite CLA 2010-05-25 10:54:34 EDT
 1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Documentation smoke test accessibility issues and broken links.

   2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

   3. Is this a regression or API breakage? Explain.

Regression.

   4. Does this require new API?

No.

   5. Who performed the code review?

Jerome Bozier

   6. Is there a test case attached to the bugzilla record?

Covered by existing test cases.

   7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Fix accessibility issues and broken links.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?

No.
Comment 6 Paul Slauenwhite CLA 2010-05-25 11:01:09 EDT
The attached patch is checked in to CVS (HEAD).
Comment 8 Paul Slauenwhite CLA 2010-05-25 13:00:53 EDT
Created attachment 169856 [details]
Patch (Part 2).
Comment 9 Paul Slauenwhite CLA 2010-05-25 13:01:23 EDT
Joel, please review patch (part 2).
Comment 10 Joel Cayne CLA 2010-05-25 13:17:42 EDT
Patch looks good.
Comment 11 Paul Slauenwhite CLA 2010-05-25 13:33:31 EDT
Resubmitting for the attached patch (part 2):

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Documentation smoke test CHKPII issues.

  2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

  3. Is this a regression or API breakage? Explain.

Regression.

  4. Does this require new API?

No.

  5. Who performed the code review?

Joel Cayne

  6. Is there a test case attached to the bugzilla record?

Covered by existing test cases.

  7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Fix CHKPII issues.

  8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?

No.
Comment 12 Eugene Chan CLA 2010-05-25 13:40:50 EDT
(In reply to comment #8)
> Created an attachment (id=169856) [details]
> Patch (Part 2).

Reviewed and approved.
Comment 13 Paul Slauenwhite CLA 2010-05-25 13:54:50 EDT
Fixing flag state.

The attached patch (part 2) is checked in to CVS (HEAD).
Comment 14 Joel Cayne CLA 2010-05-26 09:54:12 EDT
There is an error being reported in the translatability report of the latest build:
http://download.eclipse.org//tptp/4.7.0/dev/TPTP-4.7.0-201005251900/CHKPII/bad/CHKPII-plugin-org.eclipse.hyades.test.doc.user.txt
Comment 15 Paul Slauenwhite CLA 2010-05-26 14:20:52 EDT
Created attachment 170066 [details]
Patch (Part 3).
Comment 16 Paul Slauenwhite CLA 2010-05-26 14:21:15 EDT
(In reply to comment #14)
> There is an error being reported in the translatability report of the latest
> build:
> http://download.eclipse.org//tptp/4.7.0/dev/TPTP-4.7.0-201005251900/CHKPII/bad/CHKPII-plugin-org.eclipse.hyades.test.doc.user.txt

These errors are caused by the wrong DOCTYPE:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN"> --> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">

Joel, can you please review the attached patch (part 3).
Comment 17 Joel Cayne CLA 2010-05-26 14:33:42 EDT
Tested locally on the translation tool and the patch looks good.
Comment 18 Paul Slauenwhite CLA 2010-05-26 14:37:49 EDT
Resubmitting for the attached patch (part 3):

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Documentation smoke test CHKPII issues.

  2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

  3. Is this a regression or API breakage? Explain.

Regression.

  4. Does this require new API?

No.

  5. Who performed the code review?

Joel Cayne

  6. Is there a test case attached to the bugzilla record?

Covered by existing test cases.

  7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Fix CHKPII issues.

  8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?

No.
Comment 19 Kathy Chan CLA 2010-05-26 14:41:38 EDT
+1 for patch #3.
Comment 20 Paul Slauenwhite CLA 2010-05-26 14:42:49 EDT
(In reply to comment #19)
> +1 for patch #3.

The attached patch checked in to CVS (HEAD).
Comment 21 Paul Slauenwhite CLA 2010-05-27 13:59:47 EDT
Verified in TPTP-4.7.0-201005251601.

Closing.