Bugzilla – Full Text Bug Listing
| Summary: | [preferences] Abbreviate package names: improve label and add help to Appearance pref doc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Dani Megert <daniel_megert> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | trivial | ||||||
| Priority: | P3 | CC: | deepakazad, markus.kell.r | ||||
| Version: | 3.6 | Flags: | daniel_megert:
review+
markus.kell.r: review+ deepakazad: review+ |
||||
| Target Milestone: | 3.5 RC3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Dani Megert
It's not fully clear to what "matches" relates. In a chat Markus suggested: "must be a complete package name" I think the only confusion (at least for me) in the label is whether wildcards are supported or not.
For ex: I had tried to use the rule *.jdt={JDT} :)
'Left side of pattern must match whole package name'
may be replaced with
'Left side of pattern must match whole package name, wildcards are not supported'.
>I think the only confusion (at least for me) in the label is whether wildcards
>are supported or not.
Haha! Same here and then Markus pointed me to the sentence with the "matches" ;-)
I would not use the term "match".
Created attachment 169964 [details] Fix > 'Left side of pattern must match whole package name, wildcards are not > supported'. That's too long, people already don't read the current label. We should remove 'pattern' and 'matches'. Then, we don't even have to repeat that a package name is a name and not a pattern. (In reply to comment #4) > That's too long, people already don't read the current label. We should remove > 'pattern' and 'matches'. Then, we don't even have to repeat that a package name > is a name and not a pattern. Agree :) Fix looks almost good to me. When looking at it in the UI I found the mass of special chars irritating ('{JDT}.ui'; '#') and hard to read. Committed the following to HEAD:
Newline separated 'package_name=abbreviation' style abbreviation rules (e.g. rule 'org.eclipse.jdt={JDT}' will abbreviate 'org.eclipse.jdt.ui' to '{JDT}.ui').
Use '#' at beginning disables a rule:
> Use '#' at beginning disables a rule:
Fixed typo in head (disables -> to disable).
Looks good now. Verified in I20100527-1700. |