| Summary: | Platform project documentation smoke test failures. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Paul Slauenwhite <paulslau> | ||||||
| Component: | TPTP | Assignee: | Kathy Chan <kathy> | ||||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||||
| Severity: | normal | ||||||||
| Priority: | P2 | CC: | jgwest, oec | ||||||
| Version: | unspecified | Flags: | oec:
pmc_approved+
kathy: pmc_approved? (ernest) kathy: pmc_approved? (kathy) paulslau: pmc_approved+ kathy: pmc_approved? (jgwest) jgwest: review+ |
||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Paul Slauenwhite
http://download.eclipse.org/tptp/4.7.0/dev/TPTP-4.7.0-201005222133/BadOrMissingCopyrights http://download.eclipse.org/tptp/4.7.0/dev/TPTP-4.7.0-201005222133/NeedUpdate http://www.eclipse.org/tptp/home/downloads/version.php?version=4.7.0&buildID=TPTP-4.7.0-201005222133 The 4 errors in parsing file are because the following toc entries have been removed (as they should be since we are no longer shipping the logging and monitoring functions): - logging0.xml - logging2.xml - logging3.xml - monitoring.xml I suspect may be some other top level file is still refering to these files and need to be cleaned up. As for the orphan html, some of them still seems to be referenced. I'll take a closer look. Created attachment 170129 [details]
Patch 1
Patch for "error in parsing file" and orphan links. I found out that links are considered orphan if it's not linked from the TOC even though it's being referenced by other HTML pages. Deleted some unused html and added a couple to the profile.toc.
Also updated some copyright years.
Jonathan, please review. Bug 314598 has been opened to address the version number update. Created attachment 170133 [details]
Patch 2
Update copyright statement in build.xml and version number of model.hierachy.
Patch is good. I would like to request that the following defect be considered for PMC approval for 4.7.0. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? Certain profiling document pages are not showing up in the TOC. Some files has wrong copyright year. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Jonathan 6. Is there a test case attached to the bugzilla record? Platform smoke test. 7. What is the nature of the fix? What is the risk associated with this fix? Low. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? No.. Patch 1 and 2 have been checked into HEAD for TPTP 4.7.0. We'll also track http://download.eclipse.org/tptp/4.7.0/dev/TPTP-4.7.0-201005222133/NeedUpdate with bug 314598. Verified in TPTP-4.7.0RC4-201006081927. Closing. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=314598#c6 for the remaining copyright issues. |