Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314242

Summary: API removal.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact: Kathy Chan <kathy>
Severity: normal    
Priority: P1 CC: ewchan, jerome.bozier, oec, paulslau
Version: unspecifiedFlags: oec: pmc_approved+
paulslau: pmc_approved? (ernest)
paulslau: pmc_approved? (kathy)
paulslau: pmc_approved? (paulslau)
ewchan: pmc_approved+
paulslau: pmc_approved? (jgwest)
paulslau: review?
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 312807    
Bug Blocks:    
Attachments:
Description Flags
Patch.
none
Icon.
none
Patch. none

Description Paul Slauenwhite CLA 2010-05-25 06:58:56 EDT
API removal.

As a regression of defect 312807, the following API has been removed:

org.eclipse.hyades.test.tools.ui.http.TestHttpImages.IMG_CHECK
Comment 1 Paul Slauenwhite CLA 2010-05-25 07:01:48 EDT
Created attachment 169805 [details]
Patch.
Comment 2 Paul Slauenwhite CLA 2010-05-25 07:02:01 EDT
Created attachment 169806 [details]
Icon.
Comment 3 Paul Slauenwhite CLA 2010-05-25 07:02:17 EDT
Jerome, please review the attached patch.
Comment 4 Paul Slauenwhite CLA 2010-05-25 07:36:41 EDT
Created attachment 169809 [details]
Patch.
Comment 5 Bozier jerome CLA 2010-05-25 07:37:44 EDT
patch reviewed and approved
Comment 6 Paul Slauenwhite CLA 2010-05-25 07:40:18 EDT
   1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?

Breaks our API contract.

   2. Is there a work-around? If so, why do you believe the work-around is insufficient?

No.

   3. Is this a regression or API breakage? Explain.

API breakage.

   4. Does this require new API?

Reinstates a previous API.

   5. Who performed the code review?

Jerome Bozier

   6. Is there a test case attached to the bugzilla record?

Not required since this code is not used by TPTP.

   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?

Reinstates a previous API and image.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

No.
Comment 7 Eugene Chan CLA 2010-05-25 09:49:43 EDT
Patch is reviewed and safe.
Comment 8 Paul Slauenwhite CLA 2010-05-25 09:56:45 EDT
The attached patch and icon checked in to CVS (HEAD).
Comment 9 Paul Slauenwhite CLA 2010-05-26 14:02:06 EDT
Verified in http://archive.eclipse.org/tptp/4.7.0/jdiff/Testing_Tools/public/changes.html for TPTP-4.7.0-201005251900.

Closing.