Bugzilla – Full Text Bug Listing
| Summary: | linux tools package feature needs "linux filter"? | ||
|---|---|---|---|
| Product: | [Technology] EPP | Reporter: | David Williams <david_williams> |
| Component: | linuxtools-package | Assignee: | Project Inbox <epp.packager-inbox> |
| Status: | CLOSED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mknauer, overholt, pascal |
| Version: | 1.3.0 | ||
| Target Milestone: | 1.3.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
David Williams
Good point and one more thing to learn. Do you find any other ID in the log? epp.package.linuxtools? Or org.eclipse.epp.package.linuxtools.feature? I hope that it is the feature that causes the problems. I've added a filter to it now (linux, gtk, x86/x86_64) and hope that it will fix the problem, but it needs a new build (of the packages and of /releases/staging) and more testing.
>
> Do you find any other ID in the log? epp.package.linuxtools? Or
> org.eclipse.epp.package.linuxtools.feature?
>
No, just that one. And, wasn't in the log, exactly, but just in the UI and said 'can't complete the install because following isn't for your environment".
I think sometimes the "checking" stops on first failure, when it knows it won't install, it stops there, and tells you. So even if that once mentioned was changed/fixed, then there might be more (so, good to do at feature level).
One more question, because I didn't look at it in the past. I started a Helios RC1 package on Windows and used the standard 'Install new software' wizard to browse through the Helios /releases/helios repository. My expectation was that I am unable to see any of the Linux Tools IU's in the dialog because the dialog filters them out. But apparently my expectation was wrong. Or did I miss something?
Anyway, the new filter in the
org.eclipse.epp.package.linuxtools.feature.feature.group looks good to me and I expect it to behave in the same way as the other Linux Tools IUs now:
<filter>
(&(osgi.os=linux)(osgi.ws=gtk)(|(osgi.arch=x86)(osgi.arch=x86_64)))
</filter>
Pascal told me that the OS filters in our features aren't reflected in the generated metadata and thus non-Linux users *will* see our IUs in the UI. I'd love it if this weren't the case. (In reply to comment #4) > Pascal told me that the OS filters in our features aren't reflected in the > generated metadata and thus non-Linux users *will* see our IUs in the UI. I'd > love it if this weren't the case. Do you mean this as a problem with your build or p2 publisher? Or do you mean they exist in your specific repo, but are not copied over to common repo? If the later, please open a bug on b3.aggregator with details. Thanks, The way I understood it from Pascal was that the p2 UI will show all IUs on all OSes regardless of OS filter. I was under the impression that it was a missing feature in the p2 UI and nothing else. (In reply to comment #6) > The way I understood it from Pascal was that the p2 UI will show all IUs on all > OSes regardless of OS filter. I was under the impression that it was a missing > feature in the p2 UI and nothing else. Correct. >> ... it was a missing
>> feature in the p2 UI and nothing else.
> Correct.
Ok, well be sure a bug is opened there, then! :)
I see two potentially applicable p2 bugs: 272535: update-site doesn't show errors for features that are filtered based on platform https://bugs.eclipse.org/bugs/show_bug.cgi?id=272535 225365: New update site manager does not filter features based on os correctly https://bugs.eclipse.org/bugs/show_bug.cgi?id=225365 I'm marking this as a duplicate of one of the applicable p2 bugs. *** This bug has been marked as a duplicate of bug 225365 *** |