Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314158

Summary:	new look - editor area issues
Product:	[Eclipse Project] e4	Reporter:	Susan McCourt <susan>
Component:	UI	Assignee:	Susan McCourt <susan>
Status:	CLOSED WONTFIX	QA Contact:	Bogdan Gheorghe <gheorghe>
Severity:	normal
Priority:	P3	CC:	gheorghe
Version:	1.0
Target Milestone:	4.1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2010-05-24 15:50:31 EDT

This bug tracks things we need to polish in the editor area to get closer to the current mockups.

- currently the annotation bar and breakpoint bar are white, rather than the expected gray background.  This makes it hard to see where the editable area actually begins.

- in the mockups, we were playing with the idea of a local editor toolbars, and view toolbars always taking up the second row.  This likely won't be happening for 1.0.  Linda suggested some "breathing room" top margin be added if the toolbar won't be there.  One problem I foresee is that if we have a top margin without a keyline, then it will be hard to know where the editable area begins.

Comment 1 Eric Moffatt

2010-05-25 10:56:48 EDT

This is a consequence of the UI model only allowing 'MTrimBar' elements in an MTrimmedWindow. While we might consider using the TB area from the CTabFolder I expect that the reason we don't do that in 3.x is because there are always so many editors open that there's no real room for a TB...

Comment 2 Susan McCourt

2010-06-03 20:23:10 EDT

I'm going to deal with the top margin experiments and recovering the annotation bar colors.

Comment 3 Eric Moffatt

2010-06-04 11:52:23 EDT

Thanks Susan. I'm now regretting that we didn't actually model some sort of Editor Area 'frame'. Something that would allow the min/max affordance to show, give at least a place to host TB's...

Comment 4 John Arthorne

2010-07-02 14:34:04 EDT

Moving open bugs to a target milestone that is not in the past. Please adjust target as you see fit.

Comment 5 Susan McCourt

2010-08-16 15:51:07 EDT

Breaking up these placeholder bugs into more specific ones now that we have shipped.

(In reply to comment #0)
> This bug tracks things we need to polish in the editor area to get closer to
> the current mockups.
> 
> - currently the annotation bar and breakpoint bar are white, rather than the
> expected gray background.  This makes it hard to see where the editable area
> actually begins.

This is now tracked separately in bug 322833.

> 
> - in the mockups, we were playing with the idea of a local editor toolbars, and
> view toolbars always taking up the second row.  This likely won't be happening
> for 1.0.  Linda suggested some "breathing room" top margin be added if the
> toolbar won't be there.  One problem I foresee is that if we have a top margin
> without a keyline, then it will be hard to know where the editable area begins.

We've dismissed the breathing room idea and are tracking the new approach (no space at all) in bug 322834.