Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314135

Summary: need to remove most, change a few, webtools repository URL in feature.xml
Product: [WebTools] Java Server Faces Reporter: David Williams <david_williams>
Component: CoreAssignee: Raghunathan Srinivasan <raghunathan.srinivasan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: neil.hauge, raghunathan.srinivasan
Version: unspecifiedFlags: david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
neil.hauge: pmc_approved+
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: review+
Target Milestone: 3.2 RC3   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/114225
https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=1ae5a9adf9583b386ce5c6efb7d814a11f398b24
Whiteboard: PMC_approved
Bug Depends on:    
Bug Blocks: 303935    
Attachments:
Description Flags
patch to remove the incorrect update URLs
none
corrected patch none

Description David Williams CLA 2010-05-24 12:16:44 EDT 
+++ This bug was initially created as a clone of Bug #303935 +++

See bug 291637 for a broader discussion. 

In Web Tools, we have historically always used the following URL for our update sites: 

http://download.eclipse.org/webtools/updates/ 

But, this needs to change, for a few reasons. For one, (if we have to change it anyway) the term "updates" is now inaccurate or at least old-fashioned ... it is more of a "repository". 

Also, because we now want repositories to persist forever, it is too "high level". For each major release, we should have one specific to that release. Also, using the "version number" is pretty old fashioned too, and I see no reason not to use the yearly release name. such as 

http://download.eclipse.org/webtools/repository/helios


While we can (and should?) still provide 
http://download.eclipse.org/webtools/repoository 
as a viable URL, it is anticipated that, over the years, it would perform slower and slower, so it would be best to normally point people to a more specific one, for any particular release. 

And, while not normally advertised to most users, under the covers, we will have separate ("hierarchical") repositories for each maintenance or off-cycle release. Currently, I'd prefer date-time-stamp directories for these (rather than, say "SR0", "SR1", "SR2", because then "off cycle" release fit in more naturally, so these very specific URLs would look like 

http://download.eclipse.org/webtools/repository/helios/201006260900/

So, the suggestion is that for feature update URLs, the value would be 

http://download.eclipse.org/webtools/repository/helios/

We'd probably want to do this by M6, since it is "UI". (That is, might effect documentation, screen captures, or similar). 

Comments? Suggestions?
Comment 1 David Williams CLA 2010-05-24 12:19:11 EDT 
Created attachment 169692 [details]
patch to remove the incorrect update URLs

I did some "replace all" edits, and think this patch removes all the update URLs in JSF features. 

If you think JSF is somehow installed "standalone" (without XML, for example) you are welcome to add an update URL (no discovery url, please) but if you do add one, be sure to use the correct URL, as described in original bug.
Comment 2 David Williams CLA 2010-05-24 12:26:01 EDT 
Created attachment 169694 [details]
corrected patch

corrected. I noticed there had been some <url> tags with 3 URLs provided, which my mass edit didn't account for.
Comment 3 Raghunathan Srinivasan CLA 2010-05-26 14:05:36 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
 Update to feature.xml as part of work in bug 302896 . 
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
No workaround
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual testing
* Give a brief technical overview. Who has reviewed this fix? 
Fix feature update URLs
* What is the risk associated with this fix?
none
Comment 4 Raghunathan Srinivasan CLA 2010-05-27 16:31:46 EDT 
Released
Comment 5 David Williams CLA 2010-05-28 19:47:07 EDT 
Looks like the jsf_sdk feature still has the (old) url/discover links. 

They should be removed.
Comment 6 David Williams CLA 2010-05-30 03:18:53 EDT 
confirmed fixed
Comment 7 Eclipse Genie CLA 2017-12-18 20:15:48 EST 
New Gerrit change created: https://git.eclipse.org/r/114225