| Summary: | [plan] [ltw] [hcr] LTW, Reweaving and Hot Code Replace changes reflected every two saves of files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] AspectJ | Reporter: | Martin D'Aloia <martindaloia> | ||||
| Component: | LTWeaving | Assignee: | aspectj inbox <aspectj-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | aclement | ||||
| Version: | 1.6.9M2 | ||||||
| Target Milestone: | 1.6.9 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| URL: | http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg12114.html | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Martin D'Aloia
Created attachment 169687 [details]
The Eclipse test project that shows the bug
I'll try out the test project tomorrow. hotswap with ltw is still not 100% supported - up until recently it was completely banned but a couple of releases ago I removed the restrictions as people had been trying out a patch and with it 'enabled' they seemed to find it was OK (not sure what kinds of change they were making to the file though) - we have no testcases in AspectJ for it, so regressions are certainly possible. overweaving certainly shouldn't cause a class schema change - so that is interesting. as suspected, it was just showing that we are limping along with our hotswap support. The weaver is not designed to see something for a second time. I've patched it up to address this case but I'd imagine other scenarios will be lurking. I don't have a test harness to build a test for a hotswap type case but I've just tried out the fix and it does address the problem you describe. For the record: Finally I tested this with the 1.6.9.RC1 version and I can confirm that now works fine in every save. Also now works too with -Xset:overWeaving=true Great work! Thanks Andy |