Bugzilla – Full Text Bug Listing
| Summary: | [publisher] EquinoxLauncherCUAction does not generate the ini file when called from the ProductPublisherApplication | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Hugues Malphettes <hmalphettes> | ||||
| Component: | p2 | Assignee: | Ian Bull <irbull> | ||||
| Status: | RESOLVED DUPLICATE | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | hmalphettes, irbull, pascal, steeg, tjwatson | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | Juno M7 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 331974 | ||||||
| Attachments: |
|
||||||
It's not clear if this is still a problem with all the publisher work that was done recently. I will look at this for 3.7.1 Hi Ian, this issue was filed back in May 2010; before all the work that took place in the incubator. (In reply to comment #3) > Hi Ian, this issue was filed back in May 2010; before all the work that took > place in the incubator. Yes, do you know if this is still a problem, or was this addressed as part of tha work? (I don't have the code in front of me right now). I have not followed exactly what was affected and I have not checked the code yet either :/ Investigate in 3.7.2. Moving to Juno for investigation. Moving off the plan since we don't really know if this is still needed. This got fixed earlier this week. *** This bug has been marked as a duplicate of bug 377628 *** |
Created attachment 169683 [details] query the metadata repo when no advice is found. When ProductPublisherApplication is invoked the EquinoxLauncherCUAction is performed. However EquinoxLauncherCUAction#publishCU looks for the equinox launcher using: Collection<IVersionAdvice> advice = info.getAdvice(configSpec, true, id, null, IVersionAdvice.class); And this collection is empty. I suspect this works when that action is invoked by the EclipseGenerator because it has just collected all the artifacts. The patch consists of querying the metadata repository for the launcher if we find no advice for it. I kept the old code although it seems to me we might as well always query the metadata repository.