Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314127

Summary:	Problems with new build-before-launch launch configuration settings
Product:	[Tools] CDT	Reporter:	John Cortell <john.cortell>
Component:	cdt-debug	Assignee:	cdt-debug-inbox <cdt-debug-inbox>
Status:	CLOSED INVALID	QA Contact:	Ken Ryall <ken.ryall>
Severity:	normal
Priority:	P3	CC:	jamesblackburn+eclipse, pawel.1.piech
Version:	7.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description John Cortell

2010-05-24 11:27:49 EDT

1. The support for this seems to invoke an incremental build on the entire workspace instead of just the project+build configuration specified in the launch configuration. Why is that? (see AbstractCLaunchDelegate2.finalLaunchCheck())

2. These new controls appear in a CDI launch configuration, but from what I can see, there is no support for it in the CDI launcher (AbstractCLaunchDelegate)? We either need to remove the controls form the main tab or add the support in the CDI launcher.

Comment 1 John Cortell

2010-05-24 11:48:08 EDT

Disregard #1. Misread the code. #2 still applies.

Comment 2 Ken Ryall

2010-05-26 11:28:24 EDT

John, there should be support for it in AbstractCLaunchDelegate, that is where we initially contributed it for our CDI-DE launches. Perhaps I screwed it up when I did my launch delegate refactoring a few months ago.

Comment 3 John Cortell

2010-05-26 11:30:42 EDT

(In reply to comment #2)
> John, there should be support for it in AbstractCLaunchDelegate, that is where
> we initially contributed it for our CDI-DE launches. Perhaps I screwed it up
> when I did my launch delegate refactoring a few months ago.

It wouldn't be the first time I overlooked something, or imagined I saw something that wasn't there. Could you double check?

Comment 4 John Cortell

2010-06-02 08:11:37 EDT

Ken, are you planning on getting to this before the RC4 build? If not, I can take it.

Comment 5 Ken Ryall

2010-06-03 13:29:11 EDT

AbstractCLaunchDelegate seems to be using the ICDTLaunchConfigurationConstants.ATTR_BUILD_BEFORE_LAUNCH setting just as AbstractCLaunchDelegate2 does.

Comment 6 Ken Ryall

2010-06-03 13:32:23 EDT

I did a quick test and this setting seems to work for me with a CDI launch.

Comment 7 John Cortell

2010-06-03 18:23:28 EDT

Huh. Sure enough, it's there. Not sure what I was smoking that day. I remember double-checking, too. But this was during my work on bug 309126 which had me making all sorts of changes to the CDI launcher (which I later chose to abandon). I guess I must have accidentally removed some code during that work; good thing I abandoned the CDI changes.