Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314105

Summary: Folder not deleted in GitHub after local deletion
Product: [Technology] EGit Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: Konstantin.Scheglov, mn, richard.legendi, robin.rosenberg, stefan.lay
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Synchronize view, showing filesystem resources none

Description Lars Vogel CLA 2010-05-24 08:23:54 EDT 
Hello,

I have created a small project, placed it under version control with EGit and pushed it to GitHub. I had a non-source folder "presentations" with several subfolders and files in the project. I deleted this folder, added + commited locally and pushed this to GitHub.

The folder still appears in GitHub: http://github.com/vogella/test
I would expect that the folder has been removed from head and it not visible anymore in Github. I'm using the latest build from EGit with as of the time of writing is 0.8.0.

Best regards, Lars
Comment 1 Robin Rosenberg CLA 2010-05-24 16:59:28 EDT 
confirmed
Comment 2 Robin Rosenberg CLA 2010-05-28 12:23:49 EDT 
This one is worrysome since it creates a tree in a way that noone probably expects. 

One could argue that thise case should be valid, which it would if Git officially had the ability to track empty directories.
Comment 3 Stefan Lay CLA 2010-08-27 04:56:46 EDT 
Why is that a critical bug?
Comment 4 Robin Rosenberg CLA 2010-08-27 05:11:19 EDT 
(In reply to comment #1)
> confirmed

(In reply to comment #3)
> Why is that a critical bug?

It seems we might create corrupt repos, at least in the sense that
we create repos that we did not intend to do. Any creation of
an unexpected object in the repository is a serious issue when it
can be replicated undetected to other repositories. 

We might want Shawn's opinion on this one.
Comment 5 Richard O. Legendi CLA 2010-12-15 12:45:09 EST 
Created attachment 185248 [details]
Synchronize view, showing filesystem resources
Comment 6 Richard O. Legendi CLA 2010-12-15 12:46:08 EST 
I have a same problem with using EGit 0.9.1.

However if I use the Synchronize view and switch to view the file system changes, I am able to view the deletions, but cannot commit them. See attached screenshots.
Comment 7 Robin Rosenberg CLA 2010-12-19 05:37:45 EST 
See gerrit change id I897e364e476f942f8c5361a809f5fd849a972fee
Comment 8 Robin Rosenberg CLA 2011-01-12 17:47:55 EST 
Merged as 793536b04173611f49a8a4c4e105cf39c4aef052