Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314104

Summary: Icon decorations not updated
Product: [Technology] EGit Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Stefan Lay <stefan.lay>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: adietish, ekke, Lars.Vogel, stefan.lay
Version: unspecified   
Target Milestone: 0.9.0-M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Icon decorations none

Description Lars Vogel CLA 2010-05-24 08:11:12 EDT
Created attachment 169667 [details]
Icon decorations

If you overwrite an existing file in an Eclipse project the project icon decorations show you that the file is changed via the ">" sign. Screenshot attached.

If it is the same unchanged file then I believe EGit understands this and does not make a commit. Unfortunately this also seems that the icon decoration is not removed.

To test: create a new project, create folder "image", paste graphic into the folder and put the project under version control. Commit everything. Re-paste the same icon into the folder and try to get ride of the ">" sign.
Comment 1 ekkehard gentz CLA 2010-05-24 09:17:12 EDT
lars,
perhaps you run into a problem copying files

try the same using the Navigator View ;-)

ekke
Comment 2 Lars Vogel CLA 2010-05-24 09:19:14 EDT
@Ekke not sure what you mean. EGit should IMHO also work with the package explorer.
Comment 3 ekkehard gentz CLA 2010-05-24 10:20:54 EDT
@lars
...had to search the bugzilla. here it is:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=269067

...ran into the same using hgeclipse (see andrei's and my comments)

of course you're right - shouldn't matter if I'm using package explorer or navigator

ekke
Comment 4 Stefan Lay CLA 2010-08-09 07:44:10 EDT
I can not reproduce that with a current nightly build.

I would expect that commit b50d2355ce2f84c9ce1830b66879859cc70671c0 of 2010-07-19 has solved that problem. Could you please retry?

However, I can reproduce the problem mentioned by Ekke which was reported in bug 269067. I think the issue Lars described is different from the problem mentioned in 269067: Lars did not copy the resource from inside the eclipse workspace; therefore no deletion was triggerd.
Comment 5 Lars Vogel CLA 2010-08-09 11:25:41 EDT
Hi Stefan,

my error occurs if you add something to the repo. Or change something outside Eclipse. 

For example try to put an Word / OpenOffice document under version control and change it via Open with -> System Editor.

Do some changes -> the icon decorators indicate that the resource has changed.

Commit -> icon decorators still shows that the resource has changed
Comment 6 Lars Vogel CLA 2010-08-27 07:26:07 EDT
Looking forward to 0.9.0-M3.
Comment 7 Stefan Lay CLA 2010-08-30 04:41:11 EDT
(In reply to comment #5)

> For example try to put an Word / OpenOffice document under version control and
> change it via Open with -> System Editor.
> 
> Do some changes -> the icon decorators indicate that the resource has changed.
> 
> Commit -> icon decorators still shows that the resource has changed

I tried to reproduce this but to no avail. In my case the decorator vanishes.

When in this scenario do you do a workspace refresh in eclipse? I have to do it after editing the document in the external editor.
Comment 8 Lars Vogel CLA 2010-08-31 02:59:26 EDT
@Stefan: I can als not reproduce anymore. Closing as worksforme. If anyone else registered on this bug still can reproduce please re-open the bug.