Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314087

Summary: Optimize and simplify SelectSet
Product: [RT] Jetty Reporter: Greg Wilkins <gregw>
Component: serverAssignee: Simone Bordet <simone.bordet>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jetty-inbox, mgorovoy
Version: 7.1.0   
Target Milestone: 7.0.2.RC0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
work in progresss
none
work in progress II
none
simplification of select set handling none

Description Greg Wilkins CLA 2010-05-24 05:53:12 EDT 
The select manager has a lot of legacy code in it from various different ways of operating.  This should be simplified, rationalized and optimized for a the latest understanding of how NIO works.
Comment 1 Greg Wilkins CLA 2010-05-24 05:59:48 EDT 
Created attachment 169654 [details]
work in progresss

simplified changes.
blocking connects and accepts
select now tried before blocking send
Comment 2 Greg Wilkins CLA 2010-07-12 11:23:16 EDT 
Created attachment 174045 [details]
work in progress II

still more work to do
Comment 3 Greg Wilkins CLA 2010-07-15 09:14:01 EDT 
Created attachment 174395 [details]
simplification of select set handling

This patch is significantly simpler and passes all the unit tests
Comment 4 Greg Wilkins CLA 2010-07-15 09:15:45 EDT 
Simone,

can you look at this latest patch.  It simplifies the handling of select set, without being too radical.

Are there any other improvements that you think we can make without complete revolution?

cheers
Comment 5 Simone Bordet CLA 2011-03-29 05:00:39 EDT 
SelectSet has been simplified by factoring the checks for JVM bugs.
However, the patch was also removing the asynchronous connects, which turned out to be an important use case.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=337678 for further details.
Resolving as fixed by Greg's work.
Comment 6 Jesse McConnell CLA 2011-09-20 15:51:44 EDT 
Resolved -> Closed