Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 314061

Summary:

o.e.j.validation.sample is not OSGi bundle

Product:

[WebTools] WTP Common Tools

Reporter:

David Williams <david_williams>

Component:

wst.validation

Assignee:

Wini Mark <wmmark>

Status:

CLOSED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, kaloyan, neil.hauge, valentinbaciu

Version:

3.1

Flags:

david_williams: pmc_approved+
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
ccc: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kaloyan: pmc_approved+
ccc: review+

Target Milestone:

3.2 RC3

Hardware:

OS:

Windows 7

Whiteboard:

PMC_approved

Attachments:

Description	Flags
Create the MANIFEST.MF	none
New patch to add the plugin.properties and increase the version id.	ccc: iplog+

Description David Williams

2010-05-24 02:52:04 EDT

org.eclipse.jst.validation.sample

Is there a reason this test "plugin" is not a standard OSGi bundle? As it is, it is an "old fashioned" plugin, which has to be converted to a bundle before runtime. 

This started to show up during the "layout tests" such as 
http://build.eclipse.org/webtools/committers/wtp-R3.2.0-S/20100524020321/S-3.2.0RC3-20100524020321/testResults/layoutErrors.html

While we could certainly make it stop showing up there, by listing it as an exception, I think the best thing to do is to make it a proper bundle, unless there is a reason not to. It is likely to cause more concrete issues in the future (e.g. on Eclipse 4.0?) if it depends on that special plugin-to-bundle conversion that is, what 4 releases ago?

Comment 1 Carl Anderson

2010-05-24 09:09:47 EDT

While this plugin may live under the umbrella of the Java EE Tools JUnits, this is actually part of Validation.  I am routing it over to their component, however a jeetools committer will need to commit the final change (if any).

Comment 2 Wini Mark

2010-05-25 16:12:23 EDT

Created attachment 169894 [details]
Create the MANIFEST.MF

Comment 3 Carl Anderson

2010-05-25 17:23:31 EDT

Wini, 

First, with such a change, we must increase the plugin version id- at least 1.1.1.  

Second, it would be nice if we separated the strings- there should be a plugin.properties.  Select the plugin and do PDE Tools->Externalize Strings...

Comment 4 Carl Anderson

2010-05-26 09:04:10 EDT

I ran the org.eclipse.jst.validation.test.junit.AutomatedValidationBVT test with Wini's current changes, and it still passes.

Comment 5 Wini Mark

2010-05-26 10:27:22 EDT

Created attachment 170001 [details]
New patch to add the plugin.properties and increase the version id.

Comment 6 Wini Mark

2010-05-26 10:28:05 EDT

Thanks Carl. I have modified the patch with the plugin.properties and updated version id.

Comment 7 Carl Anderson

2010-05-26 10:37:05 EDT

I approve of this patch.  I also reran the test case.

Comment 8 Carl Anderson

2010-05-26 10:43:34 EDT

This ancient, but still used, test bundle was never converted to an OSGi bundle.  As such, it is impossible to fix the layout errors that Eclipse wants fixed for the Helios release.

There is no workaround.

I ran the org.eclipse.jst.validation.test.junit.AutomatedValidationBVT locally.

This is a simple conversion of the org.eclipse.jst.validation.sample plugin over to OSGi format.  I have reviewed the changes.

The only possible risk associated with this fix would be that the org.eclipse.jst.validation.test.junit.AutomatedValidationBVT would fail.

Comment 9 Carl Anderson

2010-05-26 11:17:45 EDT

Committed to HEAD for WTP 3.2 RC3

Comment 10 David Williams

2010-05-26 11:24:08 EDT

I'm all for this change. Couldn't effect function, and could revert if something odd happened to tests. 

It also appears this bundle is "unpacked" as a directory. Could it be left jarred up? Fine if not (or, fine if done later) but if you think its feasible, please update the appropriate test feature. 

Thanks for attending to this little detail.

Comment 11 Valentin Baciu

2010-06-16 13:25:07 EDT

Closing.