Bugzilla – Full Text Bug Listing
| Summary: | [publisher] EclipseLauncherParser#read does not compute correction osgiInstallArea with macosx | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Hugues Malphettes <hmalphettes> | ||||
| Component: | p2 | Assignee: | Ian Bull <irbull> | ||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | gregory.amerson, hmalphettes, irbull, steeg, tjwatson | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | Macintosh | ||||||
| OS: | All | ||||||
| Whiteboard: | stalebug | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 331974 | ||||||
| Attachments: |
|
||||||
Created attachment 169588 [details]
patch to use ParserUtils to locate the osgiinstall area
This bug would appear if the launcher's ini file was properly generated. However that is not the case when the ProductPublisher is used: https://bugs.eclipse.org/bugs/show_bug.cgi?id=314129 It's not clear if this is still a problem with all the publisher work that was done recently. I will look at this for 3.7.1 Moving to investigate in 3.7.2 Moving out. Unsetting old milestones This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. This bug was marked as stalebug a while ago. Marking as wontfix. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag. |
When executing the PublishProduct application under linux against a macosx build, the EquinoxManipulatorImpl.checkConsistencyOfFwConfigLocAndFwPersistentDataLoc fails. The issue lies in org.eclipse.equinox.internal.frameworkadmin.equinox.EclipseLauncherParser#read line 61 to 64 reads: URI osgiInstallArea = getOSGiInstallArea(lines, launcherFolder); if (osgiInstallArea == null) { osgiInstallArea = launcherData.getFwJar() != null ? ParserUtils.fromOSGiJarToOSGiInstallArea(launcherData.getFwJar().getAbsolutePath()).toURI() : launcherFolder; } This code assumes that the executable is located at the root of the eclipse installation. That is not the case for a macosx product. EclipseLauncherParser should always call ParserUtils#getOSGiInstallArea where the macosx case is supported (https://bugs.eclipse.org/bugs/show_bug.cgi?id=280007#c19) The fix consist of replacing line 61 to 64 by URI osgiInstallArea = ParserUtils.getOSGiInstallArea(lines, null, launcherData).toURI(); Workaround: if the launcher.ini file contains the -startup parameter then we are OK.