Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313996

Summary: [Intro] Slate theme Overview page looks odd with non-white window background - Fix for Eclipse 3.6.1
Product: [Eclipse Project] Platform Reporter: Martin Oberhuber <mober.at+eclipse>
Component: User AssistanceAssignee: Chris Goldthorpe <cgold>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Mike_Wilson
Version: 3.6   
Target Milestone: 3.6.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Screenshot
none
Patch
none
Revised patch none

Description Martin Oberhuber CLA 2010-05-21 19:30:47 EDT
Created attachment 169573 [details]
Screenshot

Build ID: 3.6RC2 (I20100520-1744) on WinXP SP3

See attached screenshot: When the Window background is configured not to be white, the "Overview" page of the intro in "Slate" Theme looks odd. The other themes do not expose this behavior, they look OK (all background white).

To reproduce: Windows Start > Control Panel > Display : Appearance : Advanced
Pick "Window" from dropdown, change backgorund color to cyan, apply.
Then look at the Eclipse intro.

More info: I wouldn't want to change background color myself, but I'm being told that some people (visually impaired) may want to setup their colors for maximum contrast and might thus prefer different background color (e.g. black with white text).
Comment 1 Chris Goldthorpe CLA 2010-05-26 13:23:46 EDT
Created attachment 170056 [details]
Patch

This is fairly easy to fix by setting the background for body. I will solicit opinions on whether this makes sense to release in RC3.
Comment 2 Chris Goldthorpe CLA 2010-05-26 13:45:36 EDT
Just checked with McQ and we decided to target 3.6.1. Although the fix looks very safe minor css changes have in the past had unexpected side effects on some platforms.
Comment 3 Chris Goldthorpe CLA 2010-06-21 18:28:20 EDT
Created attachment 172380 [details]
Revised patch

This patch only affects the css used by the Slate theme.
Comment 4 Chris Goldthorpe CLA 2010-06-25 14:57:04 EDT
Patch committed to 3.6 Maintenance stream, Fixed