Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313994

Summary:

[Webapp] If a toc satisfies a criterion but its children do not it is still displayed - Fix for Eclipse 3.6.1

Product:

[Eclipse Project] Platform

Reporter:

Chris Goldthorpe <cgold>

Component:

User Assistance

Assignee:

Chris Goldthorpe <cgold>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.6

Target Milestone:

3.6.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Chris Goldthorpe

2010-05-21 19:01:21 EDT

I20100520-1744

1. Install org.eclipse.ua.tests
2. Insert the lines below into the plugin customization file and start an infocenter

# Filtering by criteria
# Set true to enable criteria filtering, otherwise set false
org.eclipse.help/enableCriteria=true

# List all the supported criteria names, separated by comma 
org.eclipse.help/supportedCriteria=platform,version,containsLetter

3. Create a scope with all topics selected and under the criterion "Topic contains letter" check "letter v"

The four books which contain developer or development in the title show

4. Expand Platform Plug-in developer guide

Loading ... please wait shows and no children load

The problem is that no child topics satisfy the criterion. In this case "Platform Plug-in developer guide" should not have been shown because the toc does not have an href and no children satisfy the criteria.

Comment 1 Chris Goldthorpe

2010-05-21 19:03:51 EDT

I am targeting 3.6.1 because this does not meet the RC3 requirement for a serious bug.

Comment 2 Chris Goldthorpe

2010-06-07 14:46:33 EDT

Created attachment 171319 [details]
Patch

I reviewed the code and added more JUnit tests, there was a similar problem with topics.

Comment 3 Chris Goldthorpe

2010-06-25 17:30:12 EDT

Patch applied to 3.6 maintenance stream, Fixed.