Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313980

Summary:	[launch] done() being called on wrong progress monitor
Product:	[Eclipse Project] Platform	Reporter:	John Cortell <john.cortell>
Component:	Debug	Assignee:	Platform-Debug-Inbox <platform-debug-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	pawel.1.piech
Version:	3.5
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description John Cortell

2010-05-21 17:12:35 EDT

It seems to me the wrong monitor is being done() in

   LaunchConfigurationDelegate.buildProjects(IProject[], IProgressMonitor)

in the finally section. The method should be called on 'pm' not 'localmonitor', unless I'm mistaken. I have not witnessed a problem associated with this, but I strongly suspect the code isn't doing the right thing. Refer to the JavaDoc for 

   SubMonitor.convert(IProgressMonitor, String, int)

Comment 1 Pawel Piech

2011-06-08 00:54:23 EDT

I read the javadoc and i looked through the implementations... and I still don't know either.  But I'll take the "if it don't broke, don't fix it approach" ;-)  

Please reopen if needed.