Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313968

Summary: org.eclipse.swt.examples.source plugin contains duplicate .java files
Product: [Eclipse Project] Platform Reporter: Grant Gayed <grant_gayed>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtako, arunkumar.thondapu, david_williams, Silenio_Quarti, thanh.ha
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
sources-bundle.log none

Description Grant Gayed CLA 2010-05-21 15:20:02 EDT 
Open the org.eclipse.swt.examples.source_<version>.jar plugin in winzip, sort alphabetically by name, and note that each .java file appears twice, once in a tree starting with "src", and again in a tree starting with "swtexamplessrc".  I think the two trees are identical, except that only one of them contains the accompanying non-java files (.gif's, etc.).  SWT's other examples source plugins do not have this problem, only this one.

Also note that this isn't a new problem, this plugin looks the same in 3.5.2.
Comment 1 David Williams CLA 2013-07-24 11:03:14 EDT 
I'm not sure if this is still an issue ... but if it is, I think belongs in SWT component ... I seem to recall some on-going work to produce your source bundles for new Tycho/Maven build? 

Though, by all means, if I can help, or if does belong in 'releng' feel free to explain and move back.

Thanks.
Comment 2 Thanh Ha CLA 2013-07-24 11:24:54 EDT 
Created attachment 233757 [details]
sources-bundle.log

Happened to have a build open so thought I'd verify this real quick. I can confirm that the issue appears to still be existent. The attached log shows the contents of the source bundle.
Comment 3 Thanh Ha CLA 2013-07-24 11:52:35 EDT 
I think this has to do with the fact that build.properties seems to be a little redundant.

src.includes declares that "src/" needs to be included and there's an additional line that says "src/" should be included again as source.swtexamples.jar.


---- snippet ----
src.includes = about.html,\
               doc-html/,\
               src/

source.swtexamples.jar = src/
---- snippet ----


Would it make sense to remove "src/" from src.includes?

(this seems like the simplest solution to me)
Comment 4 Thanh Ha CLA 2013-07-24 11:53:36 EDT 
(In reply to comment #3)
> Would it make sense to remove "src/" from src.includes?
> 
> (this seems like the simplest solution to me)

From what I can tell this is what org.eclipse.swt.examples.browser does.
Comment 5 Silenio Quarti CLA 2013-07-24 13:08:52 EDT 
This seems to be already fixed in latest: 

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e8302674ef0e052e0f01c62a01ebb7440f57fc1