Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313946

Summary:	NPE when opening an editor
Product:	[Eclipse Project] e4	Reporter:	Thomas Schindl <tom.schindl>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:	Remy Suen <remy.suen>
Severity:	normal
Priority:	P3	CC:	remy.suen
Version:	1.0
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:	stalebug

Description Thomas Schindl

2010-05-21 13:24:15 EDT

tomschindl: emoffatt: i have a reproduceable NPE
[19:15] emoffatt: where ?
[19:16] tomschindl: java.lang.NullPointerException
[19:16] tomschindl: at org.eclipse.e4.workbench.ui.internal.PartServiceImpl.activate(PartServiceImpl.java:348)
[19:16] tomschindl: it's quite an nifty one
[19:16] tomschindl: and has to do with closed projects
[19:17] emoffatt: I've just fixed one but I don't think it's related...I'm fighting to get the shared parts stuff working
[19:17] tomschindl: a) Launch and create 2 projects (a and b)
[19:17] tomschindl: b) create a file in each of them
[19:17] tomschindl: c) Restart
[19:17] tomschindl: d) Close the project holding the inactive editor
[19:18] tomschindl: e) Click the editor of of the file
[19:18] tomschindl: => it tells the resource is not available
[19:18] tomschindl: f) close the editor
[19:18] emoffatt: shouldn't that editor be gone?
[19:18] tomschindl: I guess the problem is that its never been activated
[19:19] emoffatt: if you close a project that 'owns' an editor it's supposed to close
[19:19] tomschindl: and so you don't close
[19:19] tomschindl: g) Open the project
[19:19] tomschindl: h) Open the editor for the file
[19:19] tomschindl: => NPE
[19:20] emoffatt: i think the root issue is why the editor is still there after closing the project
[19:20] tomschindl: I think there's a problem with deregistering when the editor could not be launched
[19:20] tomschindl: I think you can also get in this situation if someone deletes the file out side eclipse
[19:20] emoffatt: tomschindl: see my comments, do you agree that the editor should close ?
[19:20] tomschindl: yes
[19:21] tomschindl: but as said you can get in the above situation also when deleteing the file out side of eclipse
[19:21] emoffatt: then the scenario would be impossible to get into...we have a variety of these issues around activation
[19:21] emoffatt: undoubtedly
[19:21] tomschindl: you can by manually deleteing
[19:22] tomschindl: i'm 99% sure this would lead to the same NPE
[19:22] tomschindl: I'll open a defect

Comment 1 Remy Suen

2010-05-25 08:01:31 EDT

I can't reproduce the NPE. The editor not closing is a known issue even in 3.x.

Comment 2 Thomas Schindl

2010-05-25 13:56:11 EDT

I can still reproduce 100% using the steps from above

Comment 3 Thomas Schindl

2010-05-25 13:57:25 EDT

The stack:

java.lang.NullPointerException
	at org.eclipse.e4.workbench.ui.internal.PartServiceImpl.activate(PartServiceImpl.java:354)
	at org.eclipse.ui.internal.WorkbenchPage.activate(WorkbenchPage.java:444)
	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:1833)
	at org.eclipse.ui.internal.WorkbenchPage.access$9(WorkbenchPage.java:1807)
	at org.eclipse.ui.internal.WorkbenchPage$5.run(WorkbenchPage.java:1789)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:1785)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:1769)
	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:1760)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:378)
	at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:178)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:229)
	at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:208)
	at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:274)
	at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:250)
	at org.eclipse.jdt.internal.ui.packageview.PackageExplorerActionGroup.handleOpen(PackageExplorerActionGroup.java:373)
	at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart$4.open(PackageExplorerPart.java:526)
	at org.eclipse.ui.OpenAndLinkWithEditorHelper$InternalListener.open(OpenAndLinkWithEditorHelper.java:48)
	at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:845)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:843)
	at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1131)
	at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1235)
	at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:264)
	at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:258)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:298)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3764)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1343)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1366)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1351)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1163)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3610)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3265)
	at org.eclipse.e4.ui.workbench.swt.internal.PartRenderingEngine$3.run(PartRenderingEngine.java:505)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.workbench.swt.internal.PartRenderingEngine.run(PartRenderingEngine.java:444)
	at org.eclipse.e4.workbench.ui.internal.E4Workbench.createAndRunUI(E4Workbench.java:102)
	at org.eclipse.ui.internal.Workbench$3.run(Workbench.java:534)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:520)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1383)

Comment 4 Remy Suen

2010-08-04 09:47:33 EDT

Tom, is this still a problem? I cannot reproduce with I20100803-1905 and two months has elapsed since you originally filed this.

Comment 5 Eclipse Genie

2019-01-05 20:32:35 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 6 Lars Vogel

2019-06-05 07:28:01 EDT

This is a mass change to close all e4 bugs marked with "stalebug" whiteboard.

If this bug is still valid, please reopen and remove the "stalebug" keyword.