Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313888

Summary: Translation fragments have a bad MANIFEST.MF format
Product: [Technology] Babel Reporter: Justin Dolezy <justin>
Component: PluginsAssignee: Babel Bugzilla inbox <babel.core-inbox>
Status: RESOLVED INVALID QA Contact:
Severity: major    
Priority: P3 CC: kitlo
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Justin Dolezy CLA 2010-05-21 05:44:38 EDT
Build Identifier: 20100218-1602

The translation fragments have a single blank line at the end, whereas the spec is for two.

This causes problems if you run any jar processing on these fragments (eg signing) as the whole manifest gets truncated before being written. The fragments are then not loaded by the platform as they have missing info.

Reproducible: Always
Comment 1 Kit Lo CLA 2010-05-21 07:55:38 EDT
I couldn't find the spec saying we need two bland lines at the end of a MANIFEST.MF file. Could you point me to that? I want to make sure we are following all the spec. Thanks!
Comment 2 Justin Dolezy CLA 2010-05-21 08:37:43 EDT
Hmmm maybe it's not that, although I'm sure adding a 2nd blank like has fixed this issue for me in the past in other jars. Perhaps line terminator-type issues.

As they stand, the fragments fail to sign correctly however if I run them through "jar umf org.xyz.jar" with a manifest that simply has a "Created-By: ABC" entry in it then they sign correctly without the loss of manifest entries.

Perhaps not a manifest specification issue but there's definitely some quirk of the jarprocessor/sign tool that doesn't like the files as they are!
Comment 3 Kit Lo CLA 2010-05-21 09:05:55 EDT
Thanks for the info! If you still think that we should modify the way we build the MANIFEST.MF files, please provide a sample. We will take a look. Resolve as invalid for now. Reopen if needed please.