Bugzilla – Full Text Bug Listing
| Summary: | about.html not included in build.properties | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Component: | Core | Assignee: | Raghunathan Srinivasan <raghunathan.srinivasan> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | david_williams, neil.hauge | ||||||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) raghunathan.srinivasan: pmc_approved? (deboer) neil.hauge: pmc_approved+ raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: review+ |
||||||||
| Target Milestone: | 3.2 RC3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| See Also: |
https://git.eclipse.org/r/114223 https://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=a59721ad5cf8068428eaad7ecd83d36155b1d8a9 |
||||||||||
| Whiteboard: | PMC_approved | ||||||||||
| Attachments: |
|
||||||||||
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Mission about.html files in build * Is there a work-around? If so, why do you believe the work-around is insufficient? No * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manual * Give a brief technical overview. Who has reviewed this fix? See description * What is the risk associated with this fix? none Created attachment 169518 [details]
Test Feature license
Update license in the JSF Teast feature, though, I couldn't discern the issue with the current license. I copied the license from one of the 'correct' features. Please review to see if I have addressed the issue. (In reply to comment #3) > Update license in the JSF Teast feature, though, I couldn't discern the issue > with the current license. I copied the license from one of the 'correct' > features. Please review to see if I have addressed the issue. I think it is failing because in your feature.xml file, you have %feature.license, instead of %license. And, in case you are tempted to deviate from the norm :) it really does have to be %license ... you can not change feature.properties file to match feature.license, the feature.properties must be 'license' as it is now. Thank you for attending. Created attachment 169550 [details]
Updated Fix for license in test feature
Fixed in S-3.2.0RC3-20100525145526 New Gerrit change created: https://git.eclipse.org/r/114223 Gerrit change https://git.eclipse.org/r/114223 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=a59721ad5cf8068428eaad7ecd83d36155b1d8a9 |
Created attachment 169456 [details] Patch From the build : # Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.facesconfig.tests_1.1.2.v20100428 # Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.facesconfig.ui.test_1.1.0.v20100428 # Missing pattern or file: about.html in dir: org.eclipse.jst.jsf.validation.el.tests_1.2.0.v20100428 # Missing pattern or file: about.html in dir: # Missing pattern or file: about.html in file: org.eclipse.jst.jsf.common.runtime.tests_1.1.0.v20100428.jar # Missing pattern or file: about.html in file: org.eclipse.jst.jsf.facelet.ui_1.0.0.v20100510.jar