Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313837

Summary: Merging the UML metamodel for OMG's UML 2.4 RTF
Product: [Modeling] MDT.UML2 Reporter: Nicolas Rouquette <nicolas.f.rouquette>
Component: CoreAssignee: Kenn Hussey <Kenn.Hussey>
Status: VERIFIED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: bruck.james
Version: unspecifiedFlags: Kenn.Hussey: pmc_approved+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch for Eclipse UML2 to support OMG UML2.4 RTF. Kenn.Hussey: iplog+

Description Nicolas Rouquette CLA 2010-05-20 22:33:57 EDT
During the development of the metamodel for OMG's UML 2.4 Revision Task Force (RTF), two small bugs surfaced in the Eclipse UML2 implementation of PackageMerge.

1) With default options (which we need for UML 2.4),  processing invalid subsets has undesirable side effects where, even if the subsetting is valid, then the Eclipse UML2 PackageMerge utility *adds* all valid subsets to a subsetting property. 

This behavior is undesirable; however, processing invalid subsets is a very useful option for detecting problems. Therefore, the recommendation is to only perform the processing of valid subsets *if* the subsetting is invalid and leave the subsets as specified if they are valid.

2) With default options, PackageMerge discards redundant generalizations; again, this is a desirable feature; however, the discarding is half-baked in that the generalization is only removed from the metaclass' generalization relationships but not actually destroyed in the resulting package which it should.

The patch attached is very small but it fixes these two problems.

Without this patch, we cannot properly merge the UML 2.4 metamodel for the OMG.
Comment 1 Nicolas Rouquette CLA 2010-05-20 22:36:20 EDT
Created attachment 169437 [details]
Patch for Eclipse UML2 to support OMG UML2.4 RTF.
Comment 2 Kenn Hussey CLA 2010-05-24 10:37:31 EDT
The patch looks OK (aside from some formatting tweaks). James, does this look OK to you?
Comment 3 James Bruck CLA 2010-05-24 14:46:12 EDT
(In reply to comment #2)
> The patch looks OK (aside from some formatting tweaks). James, does this look
> OK to you?

Seems fine to me.  I think the biggest use of this feature is for producing metamodels for the OMG so if they are happy with the fix, I'm happy.
Comment 4 Kenn Hussey CLA 2010-05-25 09:38:06 EDT
The fix has been committed to CVS.
Comment 5 Kenn Hussey CLA 2010-05-31 16:25:38 EDT
These changes are available in the RC3 build.