Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313783

Summary:

External settings extension point should log a warning if the ext setting provider can't be found

Product:

[Tools] CDT

Reporter:

James Blackburn <jamesblackburn+eclipse>

Component:

cdt-core

Assignee:

James Blackburn <jamesblackburn+eclipse>

Status:

RESOLVED FIXED

QA Contact:

Doug Schaefer <cdtdoug>

Severity:

normal

Priority:

Version:

7.0

Target Milestone:

7.0

Hardware:

OS:

Linux-GTK

Whiteboard:

Attachments:

Description	Flags
trivial fix	jamesblackburn+eclipse: iplog-

Description James Blackburn

2010-05-20 13:25:13 EDT

Created attachment 169381 [details]
trivial fix

I tripped over this while working on bug 310819.

If you specify an external setting provider id, and you get the ID wrong (all too easy to do as the extension point ID is auto-prefixed with the plugin ID). CDT silently ignores the failed ext setting provider.  This is bad and likely one reason extenders struggle to use this extension point.

Trivial patch to log an error if the external provider couldn't be instantiated once per session.

Comment 1 James Blackburn

2010-05-20 13:27:04 EDT

Fixed.

Comment 2 CDT Genie

2010-07-28 15:29:00 EDT

*** cdt cvs genie on behalf of jblackburn ***
Bug 313783 Log a warning if an external settings provider can't be found for the requested id

[*] CExternalSettingsManager.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java?root=Tools_Project&r1=1.19&r2=1.20
[*] ExtensionContainerFactory.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/ExtensionContainerFactory.java?root=Tools_Project&r1=1.9&r2=1.10