Bugzilla – Full Text Bug Listing
| Summary: | PackageInWarScannerTests finds lots more packages in simple-war than before | ||
|---|---|---|---|
| Product: | [RT] Gemini.Web | Reporter: | Steve Powell <zteve.powell> |
| Component: | unknown | Assignee: | Chris Frost <eclipse> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse |
| Version: | unspecified | ||
| Target Milestone: | 1.1.0.RC1-incubation | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
The current behaviour is correct and according to the history it has never contained the logback.classic jar The test is working as intended and also works on the previously included jars mentioned previously. I have added them back in to improve the quality of the test. RC1 is planned instead of milestone 5. |
Scanning for packages in war files doesn't look inside some jars (e.g. com.springsource.ch.qos.logback.classic-0.9.9) but does look inside others: (e.g. com.springsource.ch.qos.logback.classic-0.9.18) Detected when upgrading versions of above jars for CQ of test wars. Test has been adjusted, but it looks like a bug in the older version of the scanner. It appears that doScanNestedJar() in WebBundleScanner doesn't get the correct entries in the former case while ((entry = jis.getNextJarEntry()) != null) {... fails on the first try after getManifest() in the old case but succeeds in the new case. Junit test case adjusted to new result. This bug to check if behaviour is correct, and to diagnose why it didn't work before. (Looks like it may be a bug in JarInputStream?)