Bugzilla – Full Text Bug Listing
| Summary: | Deprecated TestUIUtil.getExplicitDependencies(IFile) method's replacement is internal API. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Paul Slauenwhite <paulslau> | ||||
| Component: | TPTP | Assignee: | Paul Slauenwhite <paulslau> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | alexberns, jerome.bozier, paulslau | ||||
| Version: | unspecified | Flags: | jerome.bozier:
review+
|
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | adopter | ||||||
| Attachments: |
|
||||||
|
Description
Paul Slauenwhite
We can: 1) Remove the deprecation of org.eclipse.hyades.test.ui.util.TestUIUtil.getExplicitDependencies(IFile). Note, this method causes proxies to be resolved for all test assets below the workspace root. As such, this method may be long running. 2) Implement a new method to suit your needs. Alex, what are your requirements? I need two APIs : 1) Get all dependencies for a file A from files that are referenced by A. This is done today by TestUIUtil.getExplicitDependencies(IFile) which is deprecated. 2) Get all dependencies for file A for files that reference A. Both methods need to take a progress monitor, or execute in some context where progress reporting is possible. As a potential improvement in efficiency of parsing workspaces, I suggest that both methods take lists of IFile's instead of single IFile. Created attachment 169556 [details]
Patch.
We were able to consolidate the requirements to one streamlined method (org.eclipse.hyades.test.ui.util.TestUIUtil.getReferences(List<IFile>, boolean, IProgressMonitor)). Jerome, please review and refactor the existing Test Navigator test code to use this new method. Requires a new test case. The attached patch is checked in to CVS (HEAD). (In reply to comment #5) > We were able to consolidate the requirements to one streamlined method > (org.eclipse.hyades.test.ui.util.TestUIUtil.getReferences(List<IFile>, boolean, > IProgressMonitor)). > > Jerome, please review and refactor the existing Test Navigator test code to use > this new method. Added two new context menus on test asset proxies in the Test Navigator: Example >> Inspector >> Show Implicit References Example >> Inspector >> Show Explicit References > Requires a new test case. Added four new automated test cases (including sample files) to /org.eclipse.hyades.test.ui.navigator.tests/junit_plugin/Test.UI.TestUIUtilTest.testsuite. The above test/code/files are checked in to CVS (HEAD). Verified in TPTP-4.7.0-201005222133. Closing. Jerome, could you please review this patch. patch looks good |