Bug 313635

Description Daniel Friederich 2010-05-19 18:21:46 EDT

Build Identifier: HEAD

For the TCF UDP discovery message which informs about slaves (UDP Discovery peers on a non 1534 port), the C reference implementation and the java reference implementation are using a different time base.
The java implementation uses miliseconds since 1.Jan 1970, the C implementation uses seconds. Therefore when the java implementation tell the C agent about a UDP peer, the C agent will never (well not in the next 40000 years) forget about it.

both the java and the C reference implementation support to notify about agents



Reproducible: Always

Steps to Reproduce:
TODO: I guess not too hard.
I had another machine on the local network running eclipse/tcf and I did locally run the C agent with trace output. Then when starting slaves, this produced the trace (from the C agent) below,
it shows that the C agent initially started to report the 64569/64570 slaves with seconds, then gets the time in miliseconds from the tcf java implementation and then
starts to propagate that time.


TCF 02:42.531: ACK_INFO to 127.255.255.255:1534, ID=TCP:10.82.136.36:1534
TCF 02:42.532: ACK_INFO to 127.255.255.255:1534, ID=TCP:127.0.0.1:1534
TCF 02:42.532: REQ_SLAVES from 10.82.138.15:1534
TCF 02:42.533: ACK_SLAVES (1274306530:64569:10.82.136.36) to 10.82.138.15:1534
TCF 02:42.533: ACK_SLAVES (1274306530:64570:10.82.136.36) to 10.82.138.15:1534
TCF 02:42.534: REQ_SLAVES to 10.82.138.15:1534
TCF 02:42.535: ACK_SLAVES (1274306563599:64569:10.82.136.36) from 10.82.136.36:1534
TCF 02:42.536: ACK_SLAVES (1274306563660:64570:10.82.136.36) from 10.82.136.36:1534
... Later ...
TCF 14:44.966: ACK_SLAVES (1274306563599:64569:10.82.136.36) to 10.82.138.15:1534
TCF 14:44.967: ACK_SLAVES (1274306563660:64570:10.82.136.36) to 10.82.138.15:1534

I wonder what the right way to fix this issue is (in a compatible way), I would think that using an absolute time seems a bit dangerous regardless of this offset of 1000,
I would think that using for example remaining seconds this agent should be kept (or mili seconds :-), would make more sense in case the two agents would use a different clock.