Bug 313621

Comment 1 314159abcde 2010-05-19 16:04:57 EDT

Created attachment 169210 [details]
eclipse Team shortcut keys not working

Comment 2 Mark Kirchner 2010-05-20 04:53:29 EDT

I don't think that this is subversive-related: I'm using subclipse but I've got exactly the same problem. My guess would be that the problem is PDT- (or maybe DLTK-) related, since the screenshot (the reporter has attached to the bug) shows that he's using PDT as well.

Comment 3 Igor Burilo 2010-05-20 06:17:16 EDT

I can reproduce this problem in Helios. We need to investigate the source of the problem.

Comment 4 314159abcde 2010-05-20 13:35:13 EDT

Well I am fine with any recategorization of the bug. 

If you need any additional information from me I will do my best to provide it.

Comment 5 314159abcde 2010-05-20 16:25:15 EDT

I would add that I downloaded the distribution from here: 

http://www.eclipse.org/downloads/download.php?file=/technology/epp/downloads/release/galileo/SR2/eclipse-php-galileo-SR2-win32.zip

which does say Helios on launch

Comment 6 Mark Kirchner 2010-05-21 08:32:43 EDT

> [...] shows that he's using PDT as well.
I just realized this statement might be a bit unclear, so just in order to clarify:

The original bug-reporter uses Helios, Subversive and PDT.
I'm using Helios, Subclipse and PDT (and have exactly the same problem as the reporter).

That's the reason I suggested that Subversive is not causing the problem (but PDT / DLTK might be).

Comment 7 Michael Pellaton 2010-05-23 13:10:58 EDT

I found the issue too and my tests show that neither DLTK nor PDT are the 
culprits as I have neither of them installed.

I tested with plain Eclipse SDKs as they can be downloaded:

Eclipse + Subversive = test result
3.5.2 + 0.7.8 = ok
3.5.2 + 0.7.9 = ok
3.6.M7 + 0.7.8 = fail
3.6.M7 + 0.7.9 = fail
3.6.RC1 + 0.7.8 = fail
3.6.RC1 + 0.7.9 = fail
3.6.RC2 + 0.7.8 = fail
3.6.RC2 + 0.7.9 = fail

ok = shortcuts work
fail = shortcuts do not work

The problem persists on at least Windows 32bit, Windows 64 bit, OSX 64 bit and 
Linux 64 bit - though I have not tested every combination above on every 
platform.

As shortcuts provided by other plug-ins work (eg moreunit), I assume it is indeed an issue in subversive and I suggest reassigning the bus to subversive.


IMHO this is a really bad issue that needs to be resolved for Helios.

Comment 8 314159abcde 2010-05-23 20:50:24 EDT

Mark said he has the issue but does not have Subversive installed.

What product should I categorize this bug under?

Comment 9 Michael Pellaton 2010-05-24 02:57:14 EDT

I did another test: plain Eclipse SDK without ANY extension. Then assign ctrl+alt+s to synchronize of cvs

3.5.2: works
3.6.RC2: doesn't work

Therefore I suggest failing the bug against the platform.



How to reproduce
- download Eclipse SDK
- run in new workspace
- "configure "Synchronize with Respotitory" = ctrl+alt+s
- checkout some project from a cvs
- in package explorer, select the project
- hit ctrl+alt+s
-> see what happens

For 3.5.* synchronization starts
For 3.6.* (* = > M6, have not tested earlier versions) nothing happens

Comment 10 Michael Pellaton 2010-05-24 03:29:24 EDT

Some more hints about the source of the bug:
- when assigning ctrl+alt+s to a command not part of the team ui (like about) the shortcut works as configured. So, there is no such thing as a shortcut eating monster ;-) (tested on 3.6.rc2)
- up to 3.6.m5 everything works fine
- with 3.6.m6 the bug appeared

Comment 11 Michael Pellaton 2010-05-24 03:32:49 EDT

(In reply to comment #8)
> What product should I categorize this bug under?

After what I have seen during my tests:

Product: Platform/Workbench
Component: Team

And I suggest increasing the priority a bit.

Comment 12 Igor Burilo 2010-05-25 05:13:41 EDT

It seems we need to re-assign this bug to Team component but not to PDT Editor.

Here are notes from short investigation:
I turned on debug and called Subversive's Commit action from key shortcuts:
	KEYS >>> Listener.handleEvent(type = KeyDown, stateMask = 0x0, keyCode = 0x40000, time = 10476574, character = 0x0)
	KEYS >>> Listener.handleEvent(type = KeyDown, stateMask = 0x40000, keyCode = 0x10000, time = 10476605, character = 0x0)
	KEYS >>> Listener.handleEvent(type = KeyDown, stateMask = 0x50000, keyCode = 0x63, time = 10477401, character = 0x3)
	KEYS >>> WorkbenchKeyboard.press(potentialKeyStrokes = [ALT+CTRL+C])
	KEYS >>> WorkbenchKeyboard.executeCommand(commandId = 'org.eclipse.team.svn.ui.command.CommitCommand', parameters = {})
	KEYS >>>     not handled
	COMMANDS >>> execute >>> starting: id=org.eclipse.team.svn.ui.command.CommitCommand; event=ExecutionEvent(Command(org.eclipse.team.svn.ui.command.CommitCommand,Commit...,
			Fake Commit Description,
			Category(org.eclipse.team.svn.ui.command.category,SVN,Fake description,true),
			,
			,,true),{},Event {type=1 Tree {} time=10477401 data=null x=0 y=0 width=0 height=0 detail=0},org.eclipse.core.expressions.EvaluationContext@e1c560)
	COMMANDS >>> execute >>> not handled: id=org.eclipse.team.svn.ui.command.CommitCommand; exception=org.eclipse.core.commands.NotHandledException: There is no handler to execute for command org.eclipse.team.svn.ui.command.CommitCommand.

Comment 13 Michael Pellaton 2010-05-26 05:10:14 EDT

This bug is a duplicate of Bug 306173 which was filed against Platform/Team.

As I cannot change this bug, please mark it as duplicate of that platform bug.

THX!

Comment 14 Tomasz Zarna 2010-05-26 05:23:42 EDT

*** This bug has been marked as a duplicate of bug 306173 ***