Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313609

Summary:

Border items are always clipped

Product:

[Modeling] GMF-Runtime

Reporter:

Alex Boyko <aboyko>

Component:

General

Assignee:

Alex Boyko <aboyko>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

ahunter.eclipse

Version:

2.3

Target Milestone:

2.3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Alex Boyko

2010-05-19 15:21:54 EDT

Created attachment 169194 [details]
patch

Due to Draw2D fix for Bug 312352 there is a regression in GMF on border items clipping.

New clipping strategy looks for rectangle intersections of child figure clipping rectangles with graphics clipping rectangle, while before there was one check for intersection and the check was checking child figure intersection with the graphics clipping rectangle.
BorderItemcontainerFigure#getBounds() == bounds, but BorderItemcontainer#intersects(Rectangle) == extendedBounds.intersects(Rectangle).

I don't see how IClippingStrategy can account for this... therefore i suggest adopting IClippingStrategy on BorderedNodeFigure.

I tested the patch and it looks ok to me.

Comment 1 Alex Boyko

2010-05-20 22:21:31 EDT

Delivered the fix for 2.3 RC2

Comment 2 Eclipse Webmaster

2010-07-16 23:38:16 EDT

[target cleanup] 2.3 RC was the original target milestone for this
bug

Comment 3 Eclipse Webmaster

2010-07-19 12:30:18 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug