Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313607

Summary: JAXB Classes Generation fails to resolve SYSTEM classpath variables
Product: [WebTools] Dali JPA Tools Reporter: Chris Stodden <chris.stodden>
Component: JAXBAssignee: Tran Le <tranle1>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: david_williams, nadeem.aboobaker, neil.hauge, tranle1
Version: unspecifiedFlags: david_williams: pmc_approved+
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved? (neil.hauge)
neil.hauge: pmc_approved? (kaloyan)
neil.hauge: review+
Target Milestone: 2.3 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
proposed patch none

Description Chris Stodden CLA 2010-05-19 15:16:43 EDT
Build Identifier:  I20100429-1549

When jars are added to the system classpath, the JAXB classes generation wizard fails to pick them up.  Results in a class not found exception for  com.sun.tools.xjc.XJCFacade.

Reproducible: Always

Steps to Reproduce:
1.  Create a web project
2.  In Workspace->Preferences->Java->Build Path->User Libraries add corresponding jaxb.jar and jaxb.xjc.jars to the user library.  Select System library.
3.  With a schema and corresponding jaxb bindings file attempt Generate->Jaxb Classes
Comment 1 Tran Le CLA 2010-05-19 16:41:22 EDT
Created attachment 169224 [details]
proposed patch
Comment 2 Neil Hauge CLA 2010-05-19 17:54:39 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This is an adopter (Oracle) requested fix which will affect adoption of the feature in question.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

The workaround requires the adopter to expose "system" level classes to the user in the adopting project, which is very undesirable.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Fix has been tested by the adopting product, as well as specific Dali testing to look for regressions by Tran and myself.

* Give a brief technical overview. Who has reviewed this fix? 

We have added all System level container classpaths to our collection of runtime classpaths, where as before we were only adding the system library and default project classpath.

* What is the risk associated with this fix? 

Low.  The patch only adds to the classpath content available to the launcher.  The only risk would be redundant libraries/version conflicts with these system containers and the user classpath.  This can be managed by the user if encountered.  The next version of Dali will actively manage the necessary libraries to better handle these issues.
Comment 3 David Williams CLA 2010-05-19 20:30:20 EDT
> The next version of Dali will actively manage the necessary
> libraries to better handle these issues.

Might be nice to open the future bugzilla entry now, just for improved tracking. 

Thanks much.
Comment 4 Tran Le CLA 2010-05-20 00:39:25 EDT
Checked in and released for RC2.
Thanks.