Bugzilla – Full Text Bug Listing
| Summary: | [design] separator as first menu item is not hidden | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Benjamin Muskalla <b.muskalla> | ||||
| Component: | Workbench | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 1.3 | ||||||
| Target Milestone: | 1.3 RC2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 262603 | ||||||
| Attachments: |
|
||||||
Created attachment 169351 [details]
Fix
Checks if the first menuitem is a separator. If it's a separator than it's not added to the menu.
Comment on attachment 169351 [details]
Fix
the patch looks good for me
Changes are in CVS HEAD. Thanks for reviewing. |
If you use a Separator as first item in the Menu, the design still shows the separator. In RCP / RAP without IAD, it is hidden. A use-case for this are the MB_ADDITIONS which often occur as first item in the menu. protected void fillMenuBar( final IMenuManager menuBar ) { MenuManager fileMenu = new MenuManager( "File", IWorkbenchActionConstants.M_FILE ); menuBar.add( fileMenu ); fileMenu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); fileMenu.add( importAction ); fileMenu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); fileMenu.add( exportAction ); fileMenu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS)); fileMenu.add( exitAction ); }