Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313564

Summary: Adding arbitrary output entry to build.properties creates unecessary bin.includes entry
Product: [Eclipse Project] PDE Reporter: Curtis Windatt <curtis.windatt.public>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, darin.eclipse
Version: 3.6Flags: darin.eclipse: review+
curtis.windatt.public: review+
Target Milestone: 3.6 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 309157    
Bug Blocks: 313175    
Attachments:
Description Flags
Patch
none
update none

Description Curtis Windatt CLA 2010-05-19 12:13:02 EDT 
+++ This bug was initially created as a clone of Bug #309157 +++

I20100413-1521

Steps:

* In any build.properties files, add an additional output entry that refers to nothing on the bundle classpath. For example:

output.some.jar = .

* No errors appears even though "some.jar" does not exist on the bundle classpath

Errors are properly flagged, however, I get strange secondary error with this
patch. For example:

* check out "org.eclipse.debug.core" from HEAD
* add "source.junk = junk/" to the build.properties

I get two errors:

An entry for junk/ is required in bin.includes    build.properties   
/org.eclipse.debug.core    line 11    Plug-in Problem
The specified library 'junk' is not on the plug-in classpath.   
build.properties    /org.eclipse.debug.core    line 21    Plug-in Problem


The first is wrong.
Comment 1 Ankur Sharma CLA 2010-05-19 16:38:28 EDT 
Created attachment 169220 [details]
Patch
Comment 2 Darin Wright CLA 2010-05-19 16:56:21 EDT 
Created attachment 169228 [details]
update

This is an update for this bug and bug 309157. It adds a null check (just to be safe), and changed "plug-in" to "bundle" in the error message.
Comment 3 Curtis Windatt CLA 2010-05-19 17:08:17 EDT 
Fixed as part of bug 309157
Comment 4 Curtis Windatt CLA 2010-05-19 17:09:31 EDT 
There was an extra space in the resource string that was changed.  I fixed it in HEAD.
Comment 5 Darin Wright CLA 2010-05-21 11:34:57 EDT 
Verified