Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313510

Summary: "Import specific versions(s) shown below" in Import Projects from CVS dialog needs polish
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: CVSAssignee: platform-cvs-inbox <platform-cvs-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, daniel_megert, darin.eclipse, tomasz.zarna
Version: 3.6   
Target Milestone: 3.7 M7   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Picture of Import Projects from CVS dialog
none
Patch for handling singular and plural label
daniel_megert: review-
Fix none

Description Dani Megert CLA 2010-05-19 08:18:08 EDT 
N20100517-2000.

The string "Import specific versions(s) shown below" is misleading because in some scenarios I don't see any version in the dialog, hence I have no clue about which version it talks (see attached picture).

It uses "(s)" which is a blooper: we always use correct singular or plural wording depending on the number of items.
Comment 1 Dani Megert CLA 2010-05-19 08:18:34 EDT 
Created attachment 169097 [details]
Picture of Import Projects from CVS dialog
Comment 2 Darin Wright CLA 2010-05-19 09:15:45 EDT 
The SCMURL's contain version information when produced from I-builds, releases, etc. The SCMURL's in a nightly don't contain version info, since they are built from HEAD. The wizard could likely be enhanced to recognize this.
Comment 3 Ankur Sharma CLA 2011-04-07 06:45:42 EDT 
Created attachment 192719 [details]
Patch for handling singular and plural label
Comment 4 Ankur Sharma CLA 2011-04-07 06:50:38 EDT 
The version is correctly mentioned now. Attaching the patch for correct label handling and forwarding to Team (own owns this wizard page now).
Comment 5 Dani Megert CLA 2011-04-07 10:03:15 EDT 
Comment on attachment 192719 [details]
Patch for handling singular and plural label

The patch is not really good:
1. it leaves the "(s)" in the string
2. it creates a new key but uses the same string from an existing key
3. it does not fix the issue that the version is not shown if HEAD is chosen
Comment 6 Dani Megert CLA 2011-04-07 10:03:28 EDT 
Let me fix this.
Comment 7 Dani Megert CLA 2011-04-07 10:05:21 EDT 
Created attachment 192742 [details]
Fix
Comment 8 Dani Megert CLA 2011-04-07 10:07:58 EDT 
Fixed in HEAD.
Available in builds >= N20110407-2000.