Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313427

Summary: Product preference is needed for ALLOW_CLASSPATH_DEP
Product: [WebTools] WTP Java EE Tools Reporter: Jason Peterson <jasonpet>
Component: jst.j2eeAssignee: Jason Peterson <jasonpet>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, david_williams, jsholl, raghunathan.srinivasan
Version: 3.2Flags: david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
jsholl: pmc_approved? (naci.dai)
jsholl: pmc_approved? (deboer)
jsholl: pmc_approved? (neil.hauge)
jsholl: pmc_approved? (kaloyan)
cbridgha: review+
Target Milestone: 3.2 RC3   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
patch none

Description Jason Peterson CLA 2010-05-18 15:11:43 EDT
Created attachment 169000 [details]
patch

A preference currently exist for ALLOW_CLASSPATH_DEP.  However, an adopter product would like to change the default setting for this preference from true to false.  This can be done by making it a product preference and allowing adopters to set the default for the property in the product definitions

This needs to targeted for 3.2.0 patches
Comment 1 Chuck Bridgham CLA 2010-05-18 20:16:43 EDT
approve
Comment 2 David Williams CLA 2010-05-20 13:58:26 EDT
I thought any preference would be set via product customization, and that special code wasn't needed. Do I had the wrong impression? Or is this something special WTP does? Or, am I misunderstanding? 

Thanks explaining what is probably obvious to you and others.
Comment 3 Jason Sholl CLA 2010-05-20 16:30:58 EDT
David, this code is what enables the product customizations to work.  Previously the only way to set this preference was programmatically through java.
Comment 4 Jason Sholl CLA 2010-05-20 16:34:06 EDT
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This is necessary for product customizations to work.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Yes, this has been tested both in WTP (to ensure no default behavior has changed) and by an adopter product (to ensure the product customization works).

    * Give a brief technical overview. Who has reviewed this fix? 

Simple fix to hook up product customizations.  Chuck and Jason have reviewed

    * What is the risk associated with this fix? 

None
Comment 5 David Williams CLA 2010-05-23 22:34:18 EDT
I'm assuming the overall default setting should really be 'true'? and this adopter case is the special case? Or is is being proposed this way just because its a last minute change? 

I'm fine either way, but please explain rationale for current WTP default. 

Thanks,
Comment 6 Raghunathan Srinivasan CLA 2010-05-25 09:47:12 EDT
I assume the current default is not being changed.
Comment 7 Jason Peterson CLA 2010-05-25 11:31:17 EDT
Yeah, the current default is not being changed.  It is still set as true.
Comment 8 Jason Sholl CLA 2010-05-26 13:56:43 EDT
code checked into HEAD for WTP 3.2 RC3
Comment 9 Jason Sholl CLA 2010-05-26 14:15:47 EDT
resolving