Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313412

Summary: [discovery] DiscoveryInstallOperation can install older version of a feature over a newer one
Product: [Eclipse Project] Equinox Reporter: David Dubrow <david.dubrow>
Component: p2Assignee: David Dubrow <david.dubrow>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: greensopinion, pascal, shawn.minto, steffen.pingel
Version: 3.6Flags: steffen.pingel: review+
pascal: review+
Target Milestone: 3.6 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed fix steffen.pingel: iplog+

Description David Dubrow CLA 2010-05-18 13:56:30 EDT
Created attachment 168982 [details]
proposed fix

While working with composite repositories where multiple versions may exist for the same feature, I found a bug in DiscoveryInstallOperation whereby an older version is installed over a newer one if the result of OSGIVersion.compareTo is < -1.
Comment 1 Steffen Pingel CLA 2010-05-18 17:20:22 EDT
Thanks for the bug report and patch, David. The fix looks right to me. 

Pascal, can you take a quick look as well?
Comment 2 Steffen Pingel CLA 2010-05-19 20:33:11 EDT
Thanks. Patch released.