Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 313381

Summary:

When launching with features, pressing select features button when no features available should warn user

Product:

[Eclipse Project] PDE

Reporter:

Curtis Windatt <curtis.windatt.public>

Component:

Assignee:

PDE-UI-Inbox <pde-ui-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ankur_sharma, darin.eclipse

Version:

3.6

Flags:

darin.eclipse: review+
ankur_sharma: review+

Target Milestone:

3.6 RC2

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

312646

Bug Blocks:

Attachments:

Description	Flags
Fix	none

Description Curtis Windatt

2010-05-18 11:46:49 EDT

1) Open an Eclipse launch config
2) Plug-ins Tab, Launch using features selected below.
3) Select all features
4) Press select features...

We should have a warning message saying that all features have been selected.  A better solution would be to disable the button, however, there is no easy way to do this.  In addition, if the user is only viewing selected plug-ins, there would be no explanation to the user as to why the button was disabled.

Comment 1 Ankur Sharma

2010-05-18 11:50:42 EDT

Bug #312646 already has the fix for this

Comment 2 Curtis Windatt

2010-05-18 11:51:25 EDT

Created attachment 168959 [details]
Fix

This is the fix taken from bug 312646, with the resource strings modified.  Puts up a warning message if there is nothing to select.  I had another fix that opened the selection dialog with an error message, but a message dialog is more direct.

Comment 3 Curtis Windatt

2010-05-18 11:52:20 EDT

Darin, Ankur, please review.

Comment 4 Ankur Sharma

2010-05-18 11:56:21 EDT

+1

Comment 5 Darin Wright

2010-05-18 14:11:20 EDT

Applied/Fixed.

Comment 6 Darin Wright

2010-05-21 10:52:24 EDT

Verified.